Implement mirror equality on the VM. Resolves issue 12026.

runtime/lib/mirrors_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // VM-specific implementation of the dart:mirrors library.
 
 import "dart:collection";
 
 // These values are allowed to be passed directly over the wire.
 bool _isSimpleValue(var value) {
@@ skipping 278 matching lines @@
       _LocalInstanceMirrorImpl mirror =
           reflect(invocation);
       _invokeOnClosure = reflectClass(invocation.runtimeType)
           .getField(const Symbol('_invokeOnClosure')).reflectee;
     }
     return _invokeOnClosure(reflectee, invocation);
   }
 
   String toString() => 'InstanceMirror on ${Error.safeToString(_reflectee)}';
 
+  bool operator ==(other) {
+    return other is _LocalInstanceMirrorImpl &&
+           identical(_reflectee, other._reflectee);
+  }
+
+  int get hashCode => _reflectee.hashCode;

[rmacnak, 2013/07/31 18:38:01]

_reflectee.hashCode could raise an exception. It this worth being defensive
about?

[siva, 2013/08/01 00:05:06]

Could you explain under what circumstances reflectee.hashCode can raise an
exception?

On 2013/07/31 18:38:01, Ryan Macnak wrote:

[ahe, 2013/08/06 15:28:11]

This hashCode implementation is not compatible with operator ==.
You really should use hashCode from Object.

+
   _invoke(reflectee, functionName, positionalArguments)
       native 'InstanceMirror_invoke';
 
   _invokeGetter(reflectee, getterName)
       native 'InstanceMirror_invokeGetter';
 
   _invokeSetter(reflectee, setterName, value)
       native 'InstanceMirror_invokeSetter';
 
   static _computeType(reflectee)
@@ skipping 281 matching lines @@
       return new Future.error(e);
     }
   }
 
   List<InstanceMirror> get metadata {
     // Get the metadata objects, convert them into InstanceMirrors using
     // reflect() and then make them into a Dart list.
     return _metadata(_reflectee).map(reflect).toList(growable:false);
   }
 
+  bool operator ==(other) {
+    return this.runtimeType == other.runtimeType &&

[rmacnak, 2013/07/31 18:38:01]

other.runtimeType should raise an exception. Is this worth being defensive
about?

[siva, 2013/08/01 00:05:06]

Ditto question about when an exception is raised.

On 2013/07/31 18:38:01, Ryan Macnak wrote:

+           this._reflectee == other._reflectee;
+  }
+
+  int get hashCode => simpleName.hashCode;
+
   static _name(reflectee)
       native "ClassMirror_name";
 
   static _library(reflectee)
       native "ClassMirror_library";
 
   static _supertype(reflectee)
       native "ClassMirror_supertype";
 
   static _interfaces(reflectee)
@@ skipping 75 matching lines @@
       _qualifiedName = _computeQualifiedName(owner, simpleName);
     }
     return _qualifiedName;
   }
 
   List<InstanceMirror> get metadata {
     // Get the metadata objects, convert them into InstanceMirrors using
     // reflect() and then make them into a Dart list.
     return _metadata(_reflectee).map(reflect).toList(growable:false);
   }
+
+  bool operator ==(other) {
+    return this.runtimeType == other.runtimeType &&
+           this._reflectee == other._reflectee; 
+  }
+
+  int get hashCode => simpleName.hashCode;
 }
 
 class _LazyTypeVariableMirror {
   _LazyTypeVariableMirror(String variableName, this._owner)
       : this._variableName = _s(variableName);
 
   TypeVariableMirror resolve(MirrorSystem mirrors) {
     ClassMirror owner = _owner.resolve(mirrors);
     return owner.typeVariables[_variableName];
   }
@@ skipping 189 matching lines @@
   }
 
   List<InstanceMirror> get metadata {
     // Get the metadata objects, convert them into InstanceMirrors using
     // reflect() and then make them into a Dart list.
     return _metadata(_reflectee).map(reflect).toList(growable:false);
   }
 
   String toString() => "LibraryMirror on '${_n(simpleName)}'";
 
+  bool operator ==(other) {
+    return this.runtimeType == other.runtimeType &&
+           this._reflectee == other._reflectee; 
+  }
+
+  int get hashCode => simpleName.hashCode;
+
   _invoke(reflectee, memberName, positionalArguments)
       native 'LibraryMirror_invoke';
 
   _invokeGetter(reflectee, getterName)
       native 'LibraryMirror_invokeGetter';
 
   _invokeSetter(reflectee, setterName, value)
       native 'LibraryMirror_invokeSetter';
 
   _computeMembers(reflectee)
@@ skipping 223 matching lines @@
   }
 
   Symbol get qualifiedName {
     return simpleName;
   }
 
   String toString() => "TypeMirror on '${_n(simpleName)}'";
 
   // TODO(11955): Remove once dynamicType and voidType are canonical objects in
   // the object store.
-  operator ==(other) {
+  bool operator ==(other) {
     if (other is! _SpecialTypeMirrorImpl) {
       return false;
     }
     return this.simpleName == other.simpleName;
   }
 
   int get hashCode => simpleName.hashCode;
 }
 
 class _Mirrors {
@@ skipping 43 matching lines @@
   static Expando<ClassMirror> _classMirrorCache = new Expando("ClassMirror");
   static ClassMirror reflectClass(Type key) {
     var classMirror = _classMirrorCache[key];
     if (classMirror == null) {
       classMirror = makeLocalClassMirror(key);
       _classMirrorCache[key] = classMirror;
     }
     return classMirror;
   }
 }