command_buffer: don't test the gl_clear workaround on core profile

command_buffer: don't test the gl_clear workaround on core profile

The implementation of the workaround produces a GL error on a core
profile because it doesn't use VAO, but we can't use VAOs in the
workaround because it has buggy supported on the hardware requiring this
workaround.

BUG=598902
BUG=624906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f5897213050c3187472bae46e6c12b023a976180
Cr-Commit-Position: refs/heads/master@{#404688}

[Corentin Wallez, 2016-07-11 13:59:45]

Description was changed from

==========
command_buffer: don't test the gl_clear workaround on core profile

The implementation of the workaround produces a GL error on a core
profile because it doesn't use VAO, but we can't use VAOs in the
workaround because it has buggy supported on the hardware requiring this
workaround.

BUG=598902
BUG=624906
==========

to

==========
command_buffer: don't test the gl_clear workaround on core profile

The implementation of the workaround produces a GL error on a core
profile because it doesn't use VAO, but we can't use VAOs in the
workaround because it has buggy supported on the hardware requiring this
workaround.

BUG=598902
BUG=624906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-07-11 14:00:03]

cwallez@chromium.org changed reviewers:
+ zmo@chromium.org

[Corentin Wallez, 2016-07-11 14:00:22]

PTAL, last fix needed before trying to reland the core profile patch.

[Zhenyao Mo, 2016-07-11 17:09:15]

On 2016/07/11 14:00:22, Corentin Wallez wrote:
> PTAL, last fix needed before trying to reland the core profile patch.

I didn't dig into this workaround deep, but by reading your CL description,
shouldn't we also disable this workaround on core profile if it's buggy, not
just the testing?

[Corentin Wallez, 2016-07-11 17:12:28]

On 2016/07/11 at 17:09:15, zmo wrote:
> On 2016/07/11 14:00:22, Corentin Wallez wrote:
> > PTAL, last fix needed before trying to reland the core profile patch.
> 
> I didn't dig into this workaround deep, but by reading your CL description,
shouldn't we also disable this workaround on core profile if it's buggy, not
just the testing?

The workaround is only enabled for a certain class of IMG devices that barely
support GLES 2. No core-profile context will use this workaround.

See
https://cs.chromium.org/chromium/src/gpu/config/gpu_driver_bug_list_json.cc?d...

[Zhenyao Mo, 2016-07-11 17:13:03]

lgtm

[Corentin Wallez, 2016-07-11 17:13:39]

On 2016/07/11 at 17:13:03, zmo wrote:
> lgtm

Thank you, CQing.

[Corentin Wallez, 2016-07-11 17:13:40]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-07-11 17:13:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 17:57:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-11 17:58:03]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 17:59:51]

Description was changed from

==========
command_buffer: don't test the gl_clear workaround on core profile

The implementation of the workaround produces a GL error on a core
profile because it doesn't use VAO, but we can't use VAOs in the
workaround because it has buggy supported on the hardware requiring this
workaround.

BUG=598902
BUG=624906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
command_buffer: don't test the gl_clear workaround on core profile

The implementation of the workaround produces a GL error on a core
profile because it doesn't use VAO, but we can't use VAOs in the
workaround because it has buggy supported on the hardware requiring this
workaround.

BUG=598902
BUG=624906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f5897213050c3187472bae46e6c12b023a976180
Cr-Commit-Position: refs/heads/master@{#404688}
==========

[commit-bot: I haz the power, 2016-07-11 17:59:52]

Patchset 1 (id:??) landed as
https://crrev.com/f5897213050c3187472bae46e6c12b023a976180
Cr-Commit-Position: refs/heads/master@{#404688}