Roll buildtools aa47d9773d..924d50ecae

Roll buildtools aa47d9773d..924d50ecae

  In order to roll GN b9999d69a9..4828a631a7 (r403866:r404813) and pick up
  the following changes:

  5662a80 GN: Don't define argument overrides globally
  45a841b Suggest `gn help` for internally set arguments.
  bf462ea [GN docs] Add missing word in gn actions help string
  8273381 Fix typos in GN error message

TBR=dpranke@chromium.org

Committed: https://crrev.com/932788e86f1f59cdff52df8ae78784af6f8a17e6
Cr-Commit-Position: refs/heads/master@{#405054}

[brettw, 2016-07-12 18:34:04]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:36:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-07-12 19:05:23]

lgtm

[commit-bot: I haz the power, 2016-07-12 20:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 20:58:50]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-07-13 04:59:20]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-07-13 04:59:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 06:24:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 06:25:58]

Description was changed from

==========
Roll buildtools aa47d9773d..924d50ecae

  In order to roll GN b9999d69a9..4828a631a7 (r403866:r404813) and pick up
  the following changes:

  5662a80 GN: Don't define argument overrides globally
  45a841b Suggest `gn help` for internally set arguments.
  bf462ea [GN docs] Add missing word in gn actions help string
  8273381 Fix typos in GN error message

TBR=dpranke@chromium.org
==========

to

==========
Roll buildtools aa47d9773d..924d50ecae

  In order to roll GN b9999d69a9..4828a631a7 (r403866:r404813) and pick up
  the following changes:

  5662a80 GN: Don't define argument overrides globally
  45a841b Suggest `gn help` for internally set arguments.
  bf462ea [GN docs] Add missing word in gn actions help string
  8273381 Fix typos in GN error message

TBR=dpranke@chromium.org

Committed: https://crrev.com/932788e86f1f59cdff52df8ae78784af6f8a17e6
Cr-Commit-Position: refs/heads/master@{#405054}
==========

[commit-bot: I haz the power, 2016-07-13 06:25:59]

Patchset 1 (id:??) landed as
https://crrev.com/932788e86f1f59cdff52df8ae78784af6f8a17e6
Cr-Commit-Position: refs/heads/master@{#405054}

[Reid Kleckner, 2016-07-13 15:26:30]

rnk@chromium.org changed reviewers:
+ rnk@chromium.org

[Reid Kleckner, 2016-07-13 15:26:30]

I suspect that this change might have broken the clang TOT gn bots:
https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux%20%28dbg%29/...

We're getting this now:

ERROR at build arg file (use "gn args <out_dir>" to edit):5:28: Assignment had
no effect.
llvm_force_head_revision = true
                           ^---
You set the variable "llvm_force_head_revision" here and it was unused before it
went
out of scope.
See //build/config/BUILDCONFIG.gn:463:3: which caused the file to be included.
  "//build/config/compiler:clang_stackrealign",
  ^-------------------------------------------
GN gen failed: 1

It might also be a .gn file change, I guess, but it doesn't seem like it.

[Reid Kleckner, 2016-07-13 15:57:53]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2146023002/ by rnk@chromium.org.

The reason for reverting is: Broke uses of 'clang=1 llvm_force_head_revision=1'
on clang tot waterfall:
https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot.

[Dirk Pranke, 2016-07-13 16:30:08]

On 2016/07/13 15:57:53, Reid Kleckner wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2146023002/ by mailto:rnk@chromium.org.
> 
> The reason for reverting is: Broke uses of 'clang=1
llvm_force_head_revision=1'
> on clang tot waterfall:
> https://build.chromium.org/p/chromium.fyi/console?category=clang%20tot.

Yup, reverting this or fixing the build files are the right things to do.