Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

Issue 2138003002: Remove DOMWindowProperty::willDetachGlobalObjectFromFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
diff --git a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
index 0a560cf63bccb907c90ba4708aa069737906d161..9ca5c36caaf6505174236f4d07b844b2b54b9bbc 100644
--- a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
+++ b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
@@ -19,6 +19,7 @@
#include "modules/vibration/NavigatorVibration.h"
+#include "core/dom/Document.h"
#include "core/frame/LocalFrame.h"
#include "core/frame/Navigator.h"
#include "core/frame/UseCounter.h"
@@ -30,7 +31,7 @@
namespace blink {
NavigatorVibration::NavigatorVibration(Navigator& navigator)
- : DOMWindowProperty(navigator.frame())
+ : ContextLifecycleObserver(navigator.frame()->document())
{
}
@@ -80,7 +81,7 @@ bool NavigatorVibration::vibrate(Navigator& navigator, const VibrationPattern& p
if (!frame->page()->isPageVisible())
return false;
- return NavigatorVibration::from(navigator).controller()->vibrate(pattern);
+ return NavigatorVibration::from(navigator).controller(*frame)->vibrate(pattern);
}
// static
@@ -112,15 +113,15 @@ void NavigatorVibration::collectHistogramMetrics(const LocalFrame& frame)
NavigatorVibrateHistogram.count(type);
}
-VibrationController* NavigatorVibration::controller()
+VibrationController* NavigatorVibration::controller(const LocalFrame& frame)
{
- if (!m_controller && frame())
- m_controller = new VibrationController(*frame()->document());
+ if (!m_controller)
+ m_controller = new VibrationController(*frame.document());
return m_controller.get();
}
-void NavigatorVibration::willDetachGlobalObjectFromFrame()
+void NavigatorVibration::contextDestroyed()
{
if (m_controller) {
m_controller->cancel();
@@ -132,7 +133,7 @@ DEFINE_TRACE(NavigatorVibration)
{
visitor->trace(m_controller);
Supplement<Navigator>::trace(visitor);
- DOMWindowProperty::trace(visitor);
+ ContextLifecycleObserver::trace(visitor);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698