third_party/WebKit/Source/core/frame/DOMWindowProperty.cpp - Issue 2138003002: Remove DOMWindowProperty::willDetachGlobalObjectFromFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindowProperty.cpp

Issue 2138003002: Remove DOMWindowProperty::willDetachGlobalObjectFromFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindowProperty.h ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DOMWindowProperty.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindowProperty.cpp b/third_party/WebKit/Source/core/frame/DOMWindowProperty.cpp

index 6fc921dde4b0173080f791206a402c60a694b5b8..91337808fcf307eef5d9b96aefc438364840c6b9 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindowProperty.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindowProperty.cpp

@@ -52,13 +52,6 @@ void DOMWindowProperty::willDestroyGlobalObjectInFrame()

m_frame = nullptr;

}

-void DOMWindowProperty::willDetachGlobalObjectFromFrame()

- // If the property is getting this callback it must have been

- // created with a LocalFrame and it should still have it.

- ASSERT(m_frame);

DEFINE_TRACE(DOMWindowProperty)

{

visitor->trace(m_frame);

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindowProperty.h ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »