Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: third_party/WebKit/Source/modules/vibration/NavigatorVibration.h

Issue 2138003002: Remove DOMWindowProperty::willDetachGlobalObjectFromFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/vibration/NavigatorVibration.h
diff --git a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.h b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.h
index ec978cff0a9bbb0bf7364f16500213a9aecf506c..723cf0987669bcfc29ab5f336bfb0b44633870ed 100644
--- a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.h
+++ b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.h
@@ -20,7 +20,7 @@
#ifndef NavigatorVibration_h
#define NavigatorVibration_h
-#include "core/frame/DOMWindowProperty.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "modules/ModulesExport.h"
#include "platform/Supplementable.h"
#include "platform/heap/GarbageCollected.h"
@@ -30,6 +30,7 @@
namespace blink {
+class LocalFrame;
class Navigator;
class VibrationController;
@@ -46,7 +47,7 @@ enum NavigatorVibrationType {
class MODULES_EXPORT NavigatorVibration final
: public GarbageCollectedFinalized<NavigatorVibration>
, public Supplement<Navigator>
- , public DOMWindowProperty {
+ , public ContextLifecycleObserver {
USING_GARBAGE_COLLECTED_MIXIN(NavigatorVibration);
WTF_MAKE_NONCOPYABLE(NavigatorVibration);
public:
@@ -59,7 +60,7 @@ public:
static bool vibrate(Navigator&, unsigned time);
static bool vibrate(Navigator&, const VibrationPattern&);
- VibrationController* controller();
+ VibrationController* controller(const LocalFrame&);
DECLARE_VIRTUAL_TRACE();
@@ -68,8 +69,8 @@ private:
explicit NavigatorVibration(Navigator&);
- // Inherited from DOMWindowProperty.
- void willDetachGlobalObjectFromFrame() override;
+ // Inherited from ContextLifecycleObserver.
+ void contextDestroyed() override;
static void collectHistogramMetrics(const LocalFrame&);

Powered by Google App Engine
This is Rietveld 408576698