Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h

Issue 2138003002: Remove DOMWindowProperty::willDetachGlobalObjectFromFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
diff --git a/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h b/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
index 8648d75f6061563570f95361dba231879188385d..1b245cfc9a959abb21394613e7429a3aaf26954a 100644
--- a/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
+++ b/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
@@ -26,8 +26,8 @@
#ifndef NavigatorGamepad_h
#define NavigatorGamepad_h
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/frame/DOMWindowLifecycleObserver.h"
-#include "core/frame/DOMWindowProperty.h"
#include "core/frame/PlatformEventController.h"
#include "modules/ModulesExport.h"
#include "platform/AsyncMethodRunner.h"
@@ -42,7 +42,7 @@ class Gamepad;
class GamepadList;
class Navigator;
-class MODULES_EXPORT NavigatorGamepad final : public GarbageCollectedFinalized<NavigatorGamepad>, public Supplement<Navigator>, public DOMWindowProperty, public PlatformEventController, public DOMWindowLifecycleObserver {
+class MODULES_EXPORT NavigatorGamepad final : public GarbageCollectedFinalized<NavigatorGamepad>, public Supplement<Navigator>, public ContextLifecycleObserver, public PlatformEventController, public DOMWindowLifecycleObserver {
USING_GARBAGE_COLLECTED_MIXIN(NavigatorGamepad);
public:
static NavigatorGamepad* from(Document&);
@@ -65,9 +65,8 @@ private:
void didRemoveGamepadEventListeners();
bool startUpdatingIfAttached();
- // DOMWindowProperty
- void willDestroyGlobalObjectInFrame() override;
- void willDetachGlobalObjectFromFrame() override;
+ // ContextLifecycleObserver
+ void contextDestroyed() override;
// PlatformEventController
void registerWithDispatcher() override;

Powered by Google App Engine
This is Rietveld 408576698