Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2137993002: Revert of Roll src/third_party/skia/ 443023975..48898561d (2 commits). (Closed)

Created:
4 years, 5 months ago by markusheintz_
Modified:
4 years, 5 months ago
CC:
chromium-reviews, msarett
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia/ 443023975..48898561d (2 commits). (patchset #1 id:1 of https://codereview.chromium.org/2135043002/ ) Reason for revert: Breaking webkit_tests see https://bugs.chromium.org/p/chromium/issues/detail?id=627025 Original issue's description: > Roll src/third_party/skia/ 443023975..48898561d (2 commits). > > https://chromium.googlesource.com/skia.git/+log/443023975e33..48898561db7d > > $ git log 443023975..48898561d --date=short --no-merges --format='%ad %ae %s' > 2016-07-09 pdr Update markdown docs to specify --local for the local devserver > 2016-07-09 dvonbeck Abstracted diffuse color map out of SkLightingShaderImpl into a generic SkShader > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel > TBR=msarett@google.com > > Committed: https://crrev.com/2e78db3419076fb663647615de810bbe37611fbf > Cr-Commit-Position: refs/heads/master@{#404577} TBR=msarett@google.com,skia-deps-roller@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
markusheintz_
Created Revert of Roll src/third_party/skia/ 443023975..48898561d (2 commits).
4 years, 5 months ago (2016-07-11 13:05:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137993002/1
4 years, 5 months ago (2016-07-11 13:05:35 UTC) #3
egdaniel
4 years, 5 months ago (2016-07-11 13:31:53 UTC) #5
On 2016/07/11 13:05:35, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

This should not be needed now that the suppressions have landed in chrome.

Powered by Google App Engine
This is Rietveld 408576698