Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 2137973002: Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() (Closed)

Created:
4 years, 5 months ago by hiroshige
Modified:
4 years, 5 months ago
Reviewers:
xidachen
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() ImageBitmapFactories::ImageBitmapLoader::m_options is created on the main thread and its String members should not be accessed from a non-main thread in decodeImageOnDecoderThread(). This CL passes deep copies of some |m_options| members via crossThreadBind() as arguments of decodeImageOnDecoderThread(). BUG=627048 Committed: https://crrev.com/12d642c17c4248436f45c1c551de111725827575 Cr-Commit-Position: refs/heads/master@{#404997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
hiroshige
PTAL.
4 years, 5 months ago (2016-07-12 10:33:00 UTC) #10
xidachen
lgtm Thank you so much for cleaning this up.
4 years, 5 months ago (2016-07-12 12:21:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137973002/1
4 years, 5 months ago (2016-07-12 14:30:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/199863) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-12 15:49:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137973002/1
4 years, 5 months ago (2016-07-12 16:07:25 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242666)
4 years, 5 months ago (2016-07-12 17:37:42 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137973002/1
4 years, 5 months ago (2016-07-13 03:09:20 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 04:05:17 UTC) #25
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 04:05:46 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:08:32 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12d642c17c4248436f45c1c551de111725827575
Cr-Commit-Position: refs/heads/master@{#404997}

Powered by Google App Engine
This is Rietveld 408576698