|
|
Chromium Code Reviews
DescriptionThread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread()
ImageBitmapFactories::ImageBitmapLoader::m_options is created on the main
thread and its String members should not be accessed from a non-main thread
in decodeImageOnDecoderThread().
This CL passes deep copies of some |m_options| members via crossThreadBind()
as arguments of decodeImageOnDecoderThread().
BUG=627048
Committed: https://crrev.com/12d642c17c4248436f45c1c551de111725827575
Cr-Commit-Position: refs/heads/master@{#404997}
Patch Set 1 #
Messages
Total messages: 28 (18 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() BUG= ========== to ========== Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() BUG=627048 ==========
hiroshige@chromium.org changed reviewers: + xidachen@chromium.org
Description was changed from ========== Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() BUG=627048 ========== to ========== Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() ImageBitmapFactories::ImageBitmapLoader::m_options is created on the main thread and its String members should not be accessed from a non-main thread in decodeImageOnDecoderThread(). This CL passes deep copies of some |m_options| members via crossThreadBind() as arguments of decodeImageOnDecoderThread(). BUG=627048 ==========
PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
lgtm Thank you so much for cleaning this up.
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() ImageBitmapFactories::ImageBitmapLoader::m_options is created on the main thread and its String members should not be accessed from a non-main thread in decodeImageOnDecoderThread(). This CL passes deep copies of some |m_options| members via crossThreadBind() as arguments of decodeImageOnDecoderThread(). BUG=627048 ========== to ========== Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() ImageBitmapFactories::ImageBitmapLoader::m_options is created on the main thread and its String members should not be accessed from a non-main thread in decodeImageOnDecoderThread(). This CL passes deep copies of some |m_options| members via crossThreadBind() as arguments of decodeImageOnDecoderThread(). BUG=627048 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() ImageBitmapFactories::ImageBitmapLoader::m_options is created on the main thread and its String members should not be accessed from a non-main thread in decodeImageOnDecoderThread(). This CL passes deep copies of some |m_options| members via crossThreadBind() as arguments of decodeImageOnDecoderThread(). BUG=627048 ========== to ========== Thread-Safety: Fix ImageBitmapLoader::decodeImageOnDecoderThread() ImageBitmapFactories::ImageBitmapLoader::m_options is created on the main thread and its String members should not be accessed from a non-main thread in decodeImageOnDecoderThread(). This CL passes deep copies of some |m_options| members via crossThreadBind() as arguments of decodeImageOnDecoderThread(). BUG=627048 Committed: https://crrev.com/12d642c17c4248436f45c1c551de111725827575 Cr-Commit-Position: refs/heads/master@{#404997} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/12d642c17c4248436f45c1c551de111725827575 Cr-Commit-Position: refs/heads/master@{#404997} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
