Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2137903002: MD History: Change how Clear Browsing Data is opened (Closed)

Created:
4 years, 5 months ago by tsergeant
Modified:
4 years, 5 months ago
Reviewers:
calamity, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Change how Clear Browsing Data is opened This CL changes the Clear Browsing Data button in MD History to use the same chrome.send call as the old history page. This ensures that the Settings app is opened on CrOS and that a new tab is opened on non-CrOS. BUG=621027 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a Cr-Commit-Position: refs/heads/master@{#404952}

Patch Set 1 #

Patch Set 2 : Use browser service #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/resources/md_history/browser_service.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
tsergeant
4 years, 5 months ago (2016-07-11 07:21:18 UTC) #5
Dan Beam
lgtm, could write a test, though...
4 years, 5 months ago (2016-07-12 21:31:44 UTC) #13
tsergeant
On 2016/07/12 21:31:44, Dan Beam wrote: > lgtm, could write a test, though... There aren't ...
4 years, 5 months ago (2016-07-13 01:02:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137903002/20001
4 years, 5 months ago (2016-07-13 01:06:49 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 03:21:34 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:21:43 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:23:53 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef0e6195fe0f61340de3e6516ebc7c57e085a09a
Cr-Commit-Position: refs/heads/master@{#404952}

Powered by Google App Engine
This is Rietveld 408576698