|
|
Chromium Code Reviews|
Created:
4 years, 5 months ago by Takashi Toyoshima Modified:
4 years, 5 months ago CC:
chromium-reviews, asvitkine+watch_chromium.org, tbansal1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate histograms.xml to supplement crrev.com/2095293002
WebFont.MissCachedInterventionResult was added as a variant of
WebFont.InterventionResult, but I forgot to update histograms.xml
in the CL, https://codereview.chromium.org/2095293002.
This patch also rename it to WebFont.InterventionResult.MissedCache.
BUG=578029
Committed: https://crrev.com/0b8bcea83884de8150895623e2b4d04d7c519dfd
Cr-Commit-Position: refs/heads/master@{#405022}
Patch Set 1 #
Total comments: 4
Patch Set 2 : review #4 #
Messages
Total messages: 24 (12 generated)
Description was changed from ========== Update histograms.xml to supplement crrev.com/2095293002 WebFont.MissCachedInterventionResult was added as a variant of WebFont.InterventionResult, but I forgot to update histograms.xml in the CL, https://codereview.chromium.org/2095293002. BUG=578029 ========== to ========== Update histograms.xml to supplement crrev.com/2095293002 WebFont.MissCachedInterventionResult was added as a variant of WebFont.InterventionResult, but I forgot to update histograms.xml in the CL, https://codereview.chromium.org/2095293002. BUG=578029 ==========
toyoshim@chromium.org changed reviewers: + isherman@chromium.org
Ilya, can you take a look?
lgtm https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:63224: +<histogram name="WebFont.MissCachedInterventionResult" nit: I'd have suggested naming this histogram something more like "WebFont.InterventionResult.MissedCache", though it's probably not worth losing a week and a half's worth of data just to tweak the name at this point. https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:63229: + Same with InterventionResult, this records whether User Agent Intervention nit: s/Same with/Like
https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:63224: +<histogram name="WebFont.MissCachedInterventionResult" On 2016/07/11 23:42:46, Ilya Sherman wrote: > nit: I'd have suggested naming this histogram something more like > "WebFont.InterventionResult.MissedCache", though it's probably not worth losing > a week and a half's worth of data just to tweak the name at this point. Done. https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:63229: + Same with InterventionResult, this records whether User Agent Intervention On 2016/07/11 23:42:46, Ilya Sherman wrote: > nit: s/Same with/Like Done.
toyoshim@chromium.org changed reviewers: + kinuko@chromium.org
Description was changed from ========== Update histograms.xml to supplement crrev.com/2095293002 WebFont.MissCachedInterventionResult was added as a variant of WebFont.InterventionResult, but I forgot to update histograms.xml in the CL, https://codereview.chromium.org/2095293002. BUG=578029 ========== to ========== Update histograms.xml to supplement crrev.com/2095293002 WebFont.MissCachedInterventionResult was added as a variant of WebFont.InterventionResult, but I forgot to update histograms.xml in the CL, https://codereview.chromium.org/2095293002. This patch also rename it to WebFont.InterventionResult.MissedCache. BUG=578029 ==========
+kinuko for blink side metric name change that was done based on Ilya's review.
rs/lgtm
The CQ bit was checked by toyoshim@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2137893002/#ps20001 (title: "review #4")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update histograms.xml to supplement crrev.com/2095293002 WebFont.MissCachedInterventionResult was added as a variant of WebFont.InterventionResult, but I forgot to update histograms.xml in the CL, https://codereview.chromium.org/2095293002. This patch also rename it to WebFont.InterventionResult.MissedCache. BUG=578029 ========== to ========== Update histograms.xml to supplement crrev.com/2095293002 WebFont.MissCachedInterventionResult was added as a variant of WebFont.InterventionResult, but I forgot to update histograms.xml in the CL, https://codereview.chromium.org/2095293002. This patch also rename it to WebFont.InterventionResult.MissedCache. BUG=578029 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update histograms.xml to supplement crrev.com/2095293002 WebFont.MissCachedInterventionResult was added as a variant of WebFont.InterventionResult, but I forgot to update histograms.xml in the CL, https://codereview.chromium.org/2095293002. This patch also rename it to WebFont.InterventionResult.MissedCache. BUG=578029 ========== to ========== Update histograms.xml to supplement crrev.com/2095293002 WebFont.MissCachedInterventionResult was added as a variant of WebFont.InterventionResult, but I forgot to update histograms.xml in the CL, https://codereview.chromium.org/2095293002. This patch also rename it to WebFont.InterventionResult.MissedCache. BUG=578029 Committed: https://crrev.com/0b8bcea83884de8150895623e2b4d04d7c519dfd Cr-Commit-Position: refs/heads/master@{#405022} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0b8bcea83884de8150895623e2b4d04d7c519dfd Cr-Commit-Position: refs/heads/master@{#405022} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
