Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2137893002: Update histograms.xml to supplement crrev.com/2095293002 (Closed)

Created:
4 years, 5 months ago by Takashi Toyoshima
Modified:
4 years, 5 months ago
Reviewers:
kinuko, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, tbansal1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update histograms.xml to supplement crrev.com/2095293002 WebFont.MissCachedInterventionResult was added as a variant of WebFont.InterventionResult, but I forgot to update histograms.xml in the CL, https://codereview.chromium.org/2095293002. This patch also rename it to WebFont.InterventionResult.MissedCache. BUG=578029 Committed: https://crrev.com/0b8bcea83884de8150895623e2b4d04d7c519dfd Cr-Commit-Position: refs/heads/master@{#405022}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
Takashi Toyoshima
Ilya, can you take a look?
4 years, 5 months ago (2016-07-11 06:07:43 UTC) #3
Ilya Sherman
lgtm https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/histograms.xml#newcode63224 tools/metrics/histograms/histograms.xml:63224: +<histogram name="WebFont.MissCachedInterventionResult" nit: I'd have suggested naming this ...
4 years, 5 months ago (2016-07-11 23:42:46 UTC) #4
Takashi Toyoshima
https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2137893002/diff/1/tools/metrics/histograms/histograms.xml#newcode63224 tools/metrics/histograms/histograms.xml:63224: +<histogram name="WebFont.MissCachedInterventionResult" On 2016/07/11 23:42:46, Ilya Sherman wrote: > ...
4 years, 5 months ago (2016-07-12 06:24:26 UTC) #5
Takashi Toyoshima
+kinuko for blink side metric name change that was done based on Ilya's review.
4 years, 5 months ago (2016-07-12 06:27:27 UTC) #8
kinuko
rs/lgtm
4 years, 5 months ago (2016-07-12 06:29:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137893002/20001
4 years, 5 months ago (2016-07-12 07:26:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260827)
4 years, 5 months ago (2016-07-12 08:51:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137893002/20001
4 years, 5 months ago (2016-07-12 09:29:01 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/199724)
4 years, 5 months ago (2016-07-12 11:18:36 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137893002/20001
4 years, 5 months ago (2016-07-13 02:46:51 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 04:35:50 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 04:38:01 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b8bcea83884de8150895623e2b4d04d7c519dfd
Cr-Commit-Position: refs/heads/master@{#405022}

Powered by Google App Engine
This is Rietveld 408576698