base/debug/crash_logging.cc - Issue 2137863002: Make it a compile error to use a crash key with no variable name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/crash_logging.cc

Issue 2137863002: Make it a compile error to use a crash key with no variable name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/debug/crash_logging.cc

diff --git a/base/debug/crash_logging.cc b/base/debug/crash_logging.cc

index 058b476800da3a65bd35f3b6cb2f804533986e26..8f121a67832670ec262a5107043d7f073a9b4c15 100644

--- a/base/debug/crash_logging.cc

+++ b/base/debug/crash_logging.cc

@@ -13,6 +13,9 @@

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

+// Undef the macro so the preprocessor doesn't garble the constructor.

+#undef ScopedCrashKey

namespace base {

namespace debug {

« no previous file with comments | « base/debug/crash_logging.h ('k') | no next file » | no next file with comments »