Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3611)

Unified Diff: base/debug/crash_logging_unittest.cc

Issue 2137863002: Make it a compile error to use a crash key with no variable name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/debug/crash_logging.cc ('K') | « base/debug/crash_logging.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/crash_logging_unittest.cc
diff --git a/base/debug/crash_logging_unittest.cc b/base/debug/crash_logging_unittest.cc
index 5197c03e272ccdec2dd38457ffa115bd59786ca5..20e95c95e57e558289cadc8175f0f8f9690b3f22 100644
--- a/base/debug/crash_logging_unittest.cc
+++ b/base/debug/crash_logging_unittest.cc
@@ -115,6 +115,7 @@ TEST_F(CrashLoggingTest, ScopedCrashKey) {
EXPECT_TRUE(key_values_->end() == key_values_->find(kTestKey));
{
base::debug::ScopedCrashKey scoped_crash_key(kTestKey, "value");
+ base::debug::ScopedCrashKey(kTestKey, "with no name");
EXPECT_EQ("value", (*key_values_)[kTestKey]);
EXPECT_EQ(1u, key_values_->size());
}
« base/debug/crash_logging.cc ('K') | « base/debug/crash_logging.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698