Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: net/quic/quic_stream_factory.h

Issue 2137843002: Revert of QUIC - Race Cert Verification with host resolution if certs are (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/proof_verifier_chromium_test.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory.h
diff --git a/net/quic/quic_stream_factory.h b/net/quic/quic_stream_factory.h
index 7fcb960122d74caeaf3ca2bbbda877b9f48ec129..fbb91abb3650f00e02c2d183e2e4f10f41e74381 100644
--- a/net/quic/quic_stream_factory.h
+++ b/net/quic/quic_stream_factory.h
@@ -193,7 +193,6 @@
bool migrate_sessions_on_network_change,
bool migrate_sessions_early,
bool force_hol_blocking,
- bool race_cert_verification,
const QuicTagVector& connection_options,
bool enable_token_binding);
~QuicStreamFactory() override;
@@ -366,7 +365,6 @@
private:
class Job;
- class CertVerifierJob;
friend class test::QuicStreamFactoryPeer;
FRIEND_TEST_ALL_PREFIXES(HttpStreamFactoryTest, QuicLossyProxyMarkedAsBad);
@@ -384,8 +382,6 @@
typedef std::map<QuicServerId, RequestSet> ServerIDRequestsMap;
typedef std::deque<enum QuicChromiumClientSession::QuicDisabledReason>
DisabledReasonsQueue;
- typedef std::map<QuicServerId, std::unique_ptr<CertVerifierJob>>
- CertVerifierJobMap;
enum FactoryStatus {
OPEN, // New streams may be created.
@@ -405,10 +401,8 @@
bool OnResolution(const QuicSessionKey& key, const AddressList& address_list);
void OnJobComplete(Job* job, int rv);
- void OnCertVerifyJobComplete(CertVerifierJob* job, int rv);
bool HasActiveSession(const QuicServerId& server_id) const;
bool HasActiveJob(const QuicServerId& server_id) const;
- bool HasActiveCertVerifierJob(const QuicServerId& server_id) const;
int CreateSession(const QuicSessionKey& key,
int cert_verify_flags,
std::unique_ptr<QuicServerInfo> quic_server_info,
@@ -429,13 +423,6 @@
bool WasQuicRecentlyBroken(const QuicServerId& server_id) const;
bool CryptoConfigCacheIsEmpty(const QuicServerId& server_id);
-
- // Starts an asynchronous job for cert verification if
- // |race_cert_verification_| is enabled and if there are cached certs for the
- // given |server_id|.
- QuicAsyncStatus StartCertVerifyJob(const QuicServerId& server_id,
- int cert_verify_flags,
- const BoundNetLog& net_log);
// Initializes the cached state associated with |server_id| in
// |crypto_config_| with the information in |server_info|. Populates
@@ -503,8 +490,6 @@
JobMap active_jobs_;
ServerIDRequestsMap job_requests_map_;
RequestMap active_requests_;
-
- CertVerifierJobMap active_cert_verifier_jobs_;
QuicVersionVector supported_versions_;
@@ -591,9 +576,6 @@
// If set, force HOL blocking. For measurement purposes.
const bool force_hol_blocking_;
- // Set if cert verification is to be raced with host resolution.
- bool race_cert_verification_;
-
// Each profile will (probably) have a unique port_seed_ value. This value
// is used to help seed a pseudo-random number generator (PortSuggester) so
// that we consistently (within this profile) suggest the same ephemeral
« no previous file with comments | « net/quic/crypto/proof_verifier_chromium_test.cc ('k') | net/quic/quic_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698