Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: public/web/WebDOMActivityLogger.h

Issue 213783002: Pass current value of attributes to WebDOMActivityLogger Setter logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase to pull attribute changes into separate CL Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebDOMActivityLogger.h
diff --git a/public/web/WebDOMActivityLogger.h b/public/web/WebDOMActivityLogger.h
index 9664be511079edd673e0f8a3ae8e967eb9b86705..6079e8e2edc47ef4096332f57127c0f98c254930 100644
--- a/public/web/WebDOMActivityLogger.h
+++ b/public/web/WebDOMActivityLogger.h
@@ -41,7 +41,14 @@ namespace blink {
class WebDOMActivityLogger {
public:
virtual ~WebDOMActivityLogger() { }
+
+ // DEPRECATED: Only for chrome compilation during blink rolls.
virtual void log(const WebString& apiName, int argc, const v8::Handle<v8::Value>* argv, const WebString& extraInfo, const WebURL& url, const WebString& title) { }
abarth-chromium 2014/04/24 14:48:22 You should be able to remove this function. Chrom
Devlin 2014/04/24 16:40:35 Chromium does use the OVERRIDE keyword. Relevant
+
+ virtual void logGetter(const WebString& apiName, const WebURL& url, const WebString& title) { }
+ virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value>& newValue, const WebURL& url, const WebString& title) { }
+ virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value>& newValue, const v8::Handle<v8::Value>& oldValue, const WebURL& url, const WebString& title) { }
+ virtual void logMethod(const WebString& apiName, int argc, const v8::Handle<v8::Value>* argv, const WebURL& url, const WebString& title) { }
};
// Checks if a logger already exists for the world identified
« Source/bindings/templates/attributes.cpp ('K') | « Source/web/WebDOMActivityLogger.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698