Chromium Code Reviews| Index: public/web/WebDOMActivityLogger.h |
| diff --git a/public/web/WebDOMActivityLogger.h b/public/web/WebDOMActivityLogger.h |
| index 9664be511079edd673e0f8a3ae8e967eb9b86705..6079e8e2edc47ef4096332f57127c0f98c254930 100644 |
| --- a/public/web/WebDOMActivityLogger.h |
| +++ b/public/web/WebDOMActivityLogger.h |
| @@ -41,7 +41,14 @@ namespace blink { |
| class WebDOMActivityLogger { |
| public: |
| virtual ~WebDOMActivityLogger() { } |
| + |
| + // DEPRECATED: Only for chrome compilation during blink rolls. |
| virtual void log(const WebString& apiName, int argc, const v8::Handle<v8::Value>* argv, const WebString& extraInfo, const WebURL& url, const WebString& title) { } |
|
abarth-chromium
2014/04/24 14:48:22
You should be able to remove this function. Chrom
Devlin
2014/04/24 16:40:35
Chromium does use the OVERRIDE keyword. Relevant
|
| + |
| + virtual void logGetter(const WebString& apiName, const WebURL& url, const WebString& title) { } |
| + virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value>& newValue, const WebURL& url, const WebString& title) { } |
| + virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value>& newValue, const v8::Handle<v8::Value>& oldValue, const WebURL& url, const WebString& title) { } |
| + virtual void logMethod(const WebString& apiName, int argc, const v8::Handle<v8::Value>* argv, const WebURL& url, const WebString& title) { } |
| }; |
| // Checks if a logger already exists for the world identified |