Chromium Code Reviews| Index: Source/bindings/scripts/v8_attributes.py |
| diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py |
| index 3ba0ca64dc93ae82175d269a008882e96f1d7109..280379213dfbce67e7f34069bbc97541a7174293 100644 |
| --- a/Source/bindings/scripts/v8_attributes.py |
| +++ b/Source/bindings/scripts/v8_attributes.py |
| @@ -82,12 +82,14 @@ def generate_attribute(interface, attribute): |
| 'access_control_list': access_control_list(attribute), |
| 'activity_logging_world_list_for_getter': v8_utilities.activity_logging_world_list(attribute, 'Getter'), # [ActivityLogging] |
| 'activity_logging_world_list_for_setter': v8_utilities.activity_logging_world_list(attribute, 'Setter'), # [ActivityLogging] |
| + 'activity_logging_include_old_value_for_setter': 'LogPreviousValue' in extended_attributes, # [ActivityLogging] |
| 'cached_attribute_validation_method': extended_attributes.get('CachedAttribute'), |
| 'conditional_string': v8_utilities.conditional_string(attribute), |
| 'constructor_type': idl_type.constructor_type_name |
| if is_constructor_attribute(attribute) else None, |
| 'cpp_name': cpp_name(attribute), |
| 'cpp_type': idl_type.cpp_type, |
| + 'cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value(cpp_value='original', creation_context='v8::Handle<v8::Object>()'), |
|
abarth-chromium
2014/04/24 14:48:22
v8::Handle<v8::Object>() isn't the right ceration
Devlin
2014/04/24 16:40:35
Is the correct context '' then, as it's the defaul
Nils Barth (inactive)
2014/04/25 01:45:41
+haraken?
(What's the correct creation context her
haraken
2014/04/25 01:50:49
I got confused.
I cannot find any "v8::Handle<v8:
Nils Barth (inactive)
2014/04/25 01:54:52
That's a good point.
|
| 'deprecate_as': v8_utilities.deprecate_as(attribute), # [DeprecateAs] |
| 'enum_validation_expression': idl_type.enum_validation_expression, |
| 'has_custom_getter': has_custom_getter, |