Index: Source/bindings/templates/attributes.cpp |
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp |
index d503e60014019dd4f707f9ae48b34c9fb68c7d4e..e238e2d0c67aa6933422873890220480ae729e99 100644 |
--- a/Source/bindings/templates/attributes.cpp |
+++ b/Source/bindings/templates/attributes.cpp |
@@ -171,7 +171,7 @@ v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info |
{% if world_suffix in attribute.activity_logging_world_list_for_getter %} |
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext()); |
if (contextData && contextData->activityLogger()) |
- contextData->activityLogger()->log("{{interface_name}}.{{attribute.name}}", 0, 0, "Getter"); |
+ contextData->activityLogger()->logGetter("{{interface_name}}.{{attribute.name}}"); |
{% endif %} |
{% if attribute.has_custom_getter %} |
{{v8_class}}::{{attribute.name}}AttributeGetterCustom(info); |
@@ -311,8 +311,18 @@ v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackI |
{% if world_suffix in attribute.activity_logging_world_list_for_setter %} |
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext()); |
if (contextData && contextData->activityLogger()) { |
- v8::Handle<v8::Value> loggerArg[] = { v8Value }; |
- contextData->activityLogger()->log("{{interface_name}}.{{attribute.name}}", 1, &loggerArg[0], "Setter"); |
+ {% if attribute.activity_logging_include_old_value_for_setter %} |
+ {{cpp_class}}* impl = {{v8_class}}::toNative(info.Holder()); |
+ {% if attribute.cpp_value_original %} |
+ {{attribute.cpp_type}} original = {{attribute.cpp_value_original}}; |
+ {% else %} |
+ {{attribute.cpp_type}} original = {{attribute.cpp_value}}; |
+ {% endif %} |
+ v8::Handle<v8::Value> originalValue = {{attribute.cpp_value_to_v8_value}}; |
+ contextData->activityLogger()->logSetter("{{interface_name}}.{{attribute.name}}", v8Value, originalValue); |
+ {% else %} |
+ contextData->activityLogger()->logSetter("{{interface_name}}.{{attribute.name}}", v8Value); |
+ {% endif %} |
} |
{% endif %} |
{% if attribute.is_custom_element_callbacks or attribute.is_reflect %} |