Source/bindings/scripts/v8_attributes.py - Issue 213783002: Pass current value of attributes to WebDOMActivityLogger Setter logs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 213783002: Pass current value of attributes to WebDOMActivityLogger Setter logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Nils's Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 3ba0ca64dc93ae82175d269a008882e96f1d7109..d79a8985c27e10ac1befc45ad703d1fb2c91e12b 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -82,12 +82,14 @@ def generate_attribute(interface, attribute):

'access_control_list': access_control_list(attribute),

'activity_logging_world_list_for_getter': v8_utilities.activity_logging_world_list(attribute, 'Getter'), # [ActivityLogging]

'activity_logging_world_list_for_setter': v8_utilities.activity_logging_world_list(attribute, 'Setter'), # [ActivityLogging]

+ 'activity_logging_include_old_value_for_setter': ('LogPreviousValue' in extended_attributes), # [ActivityLogging]

Nils Barth (inactive) 2014/04/23 03:04:42 No parentheses. (Only need if doing line continuat

Devlin 2014/04/23 18:28:02 Done.

'cached_attribute_validation_method': extended_attributes.get('CachedAttribute'),

'conditional_string': v8_utilities.conditional_string(attribute),

'constructor_type': idl_type.constructor_type_name

if is_constructor_attribute(attribute) else None,

'cpp_name': cpp_name(attribute),

'cpp_type': idl_type.cpp_type,

+ 'cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value(cpp_value='original', isolate='info.GetIsolate()', creation_context='v8::Handle<v8::Object>()'),

Nils Barth (inactive) 2014/04/23 03:04:42 Don't need isolate='info.GetIsolate()', as that's

Devlin 2014/04/23 18:28:02 Ah, so it is. Removed.

'deprecate_as': v8_utilities.deprecate_as(attribute), # [DeprecateAs]

'enum_validation_expression': idl_type.enum_validation_expression,

'has_custom_getter': has_custom_getter,

« no previous file with comments | « Source/bindings/IDLExtendedAttributes.txt ('k') | Source/bindings/scripts/v8_utilities.py » ('j') | Source/bindings/scripts/v8_utilities.py » ('J')