Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 213783002: Pass current value of attributes to WebDOMActivityLogger Setter logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/bindings/templates/attributes.cpp ('K') | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/results/V8TestObjectPython.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index 7fc50bb5eb6b34fae7a968382a0b380fc8d3f8a8..5e1e517d57012a7879d2eb168611efe1683d6d83 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -2516,7 +2516,7 @@ static void activityLoggedAttr1AttributeGetterCallback(v8::Local<v8::String>, co
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger())
- contextData->activityLogger()->log("TestObject.activityLoggedAttr1", 0, 0, "Getter");
+ contextData->activityLogger()->logGetter("TestObject.activityLoggedAttr1");
TestObjectV8Internal::activityLoggedAttr1AttributeGetter(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
@@ -2534,8 +2534,8 @@ static void activityLoggedAttr1AttributeSetterCallback(v8::Local<v8::String>, v8
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
- v8::Handle<v8::Value> loggerArg[] = { jsValue };
- contextData->activityLogger()->log("TestObject.activityLoggedAttr1", 1, &loggerArg[0], "Setter");
+ v8::Handle<v8::Value> HACK;
+ contextData->activityLogger()->logSetter("TestObject.activityLoggedAttr1", jsValue, HACK);
}
TestObjectV8Internal::activityLoggedAttr1AttributeSetter(jsValue, info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -2552,7 +2552,7 @@ static void activityLoggedAttr2AttributeGetterCallback(v8::Local<v8::String>, co
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger())
- contextData->activityLogger()->log("TestObject.activityLoggedAttr2", 0, 0, "Getter");
+ contextData->activityLogger()->logGetter("TestObject.activityLoggedAttr2");
TestObjectV8Internal::activityLoggedAttr2AttributeGetter(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
@@ -2570,8 +2570,8 @@ static void activityLoggedAttr2AttributeSetterCallback(v8::Local<v8::String>, v8
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
- v8::Handle<v8::Value> loggerArg[] = { jsValue };
- contextData->activityLogger()->log("TestObject.activityLoggedAttr2", 1, &loggerArg[0], "Setter");
+ v8::Handle<v8::Value> HACK;
+ contextData->activityLogger()->logSetter("TestObject.activityLoggedAttr2", jsValue, HACK);
}
TestObjectV8Internal::activityLoggedAttr2AttributeSetter(jsValue, info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -2588,7 +2588,7 @@ static void activityLoggedAttr2AttributeGetterCallbackForMainWorld(v8::Local<v8:
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger())
- contextData->activityLogger()->log("TestObject.activityLoggedAttr2", 0, 0, "Getter");
+ contextData->activityLogger()->logGetter("TestObject.activityLoggedAttr2");
TestObjectV8Internal::activityLoggedAttr2AttributeGetterForMainWorld(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
@@ -2606,8 +2606,8 @@ static void activityLoggedAttr2AttributeSetterCallbackForMainWorld(v8::Local<v8:
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
- v8::Handle<v8::Value> loggerArg[] = { jsValue };
- contextData->activityLogger()->log("TestObject.activityLoggedAttr2", 1, &loggerArg[0], "Setter");
+ v8::Handle<v8::Value> HACK;
+ contextData->activityLogger()->logSetter("TestObject.activityLoggedAttr2", jsValue, HACK);
}
TestObjectV8Internal::activityLoggedAttr2AttributeSetterForMainWorld(jsValue, info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -2624,7 +2624,7 @@ static void activityLoggedInIsolatedWorldsAttrAttributeGetterCallback(v8::Local<
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger())
- contextData->activityLogger()->log("TestObject.activityLoggedInIsolatedWorldsAttr", 0, 0, "Getter");
+ contextData->activityLogger()->logGetter("TestObject.activityLoggedInIsolatedWorldsAttr");
TestObjectV8Internal::activityLoggedInIsolatedWorldsAttrAttributeGetter(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
@@ -2642,8 +2642,8 @@ static void activityLoggedInIsolatedWorldsAttrAttributeSetterCallback(v8::Local<
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
- v8::Handle<v8::Value> loggerArg[] = { jsValue };
- contextData->activityLogger()->log("TestObject.activityLoggedInIsolatedWorldsAttr", 1, &loggerArg[0], "Setter");
+ v8::Handle<v8::Value> HACK;
+ contextData->activityLogger()->logSetter("TestObject.activityLoggedInIsolatedWorldsAttr", jsValue, HACK);
}
TestObjectV8Internal::activityLoggedInIsolatedWorldsAttrAttributeSetter(jsValue, info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -2703,8 +2703,8 @@ static void activityLoggedAttrSetter1AttributeSetterCallback(v8::Local<v8::Strin
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
- v8::Handle<v8::Value> loggerArg[] = { jsValue };
- contextData->activityLogger()->log("TestObject.activityLoggedAttrSetter1", 1, &loggerArg[0], "Setter");
+ v8::Handle<v8::Value> HACK;
+ contextData->activityLogger()->logSetter("TestObject.activityLoggedAttrSetter1", jsValue, HACK);
}
TestObjectV8Internal::activityLoggedAttrSetter1AttributeSetter(jsValue, info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -2736,8 +2736,8 @@ static void activityLoggedAttrSetter2AttributeSetterCallback(v8::Local<v8::Strin
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
- v8::Handle<v8::Value> loggerArg[] = { jsValue };
- contextData->activityLogger()->log("TestObject.activityLoggedAttrSetter2", 1, &loggerArg[0], "Setter");
+ v8::Handle<v8::Value> HACK;
+ contextData->activityLogger()->logSetter("TestObject.activityLoggedAttrSetter2", jsValue, HACK);
}
TestObjectV8Internal::activityLoggedAttrSetter2AttributeSetter(jsValue, info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -2769,8 +2769,8 @@ static void activityLoggedAttrSetter2AttributeSetterCallbackForMainWorld(v8::Loc
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
- v8::Handle<v8::Value> loggerArg[] = { jsValue };
- contextData->activityLogger()->log("TestObject.activityLoggedAttrSetter2", 1, &loggerArg[0], "Setter");
+ v8::Handle<v8::Value> HACK;
+ contextData->activityLogger()->logSetter("TestObject.activityLoggedAttrSetter2", jsValue, HACK);
}
TestObjectV8Internal::activityLoggedAttrSetter2AttributeSetterForMainWorld(jsValue, info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -2802,8 +2802,8 @@ static void activityLoggedInIsolatedWorldsAttrSetterAttributeSetterCallback(v8::
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMSetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
- v8::Handle<v8::Value> loggerArg[] = { jsValue };
- contextData->activityLogger()->log("TestObject.activityLoggedInIsolatedWorldsAttrSetter", 1, &loggerArg[0], "Setter");
+ v8::Handle<v8::Value> HACK;
+ contextData->activityLogger()->logSetter("TestObject.activityLoggedInIsolatedWorldsAttrSetter", jsValue, HACK);
}
TestObjectV8Internal::activityLoggedInIsolatedWorldsAttrSetterAttributeSetter(jsValue, info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -2848,7 +2848,7 @@ static void activityLoggedAttrGetter1AttributeGetterCallback(v8::Local<v8::Strin
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger())
- contextData->activityLogger()->log("TestObject.activityLoggedAttrGetter1", 0, 0, "Getter");
+ contextData->activityLogger()->logGetter("TestObject.activityLoggedAttrGetter1");
TestObjectV8Internal::activityLoggedAttrGetter1AttributeGetter(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
@@ -2879,7 +2879,7 @@ static void activityLoggedAttrGetter2AttributeGetterCallback(v8::Local<v8::Strin
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger())
- contextData->activityLogger()->log("TestObject.activityLoggedAttrGetter2", 0, 0, "Getter");
+ contextData->activityLogger()->logGetter("TestObject.activityLoggedAttrGetter2");
TestObjectV8Internal::activityLoggedAttrGetter2AttributeGetter(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
@@ -2910,7 +2910,7 @@ static void activityLoggedAttrGetter2AttributeGetterCallbackForMainWorld(v8::Loc
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger())
- contextData->activityLogger()->log("TestObject.activityLoggedAttrGetter2", 0, 0, "Getter");
+ contextData->activityLogger()->logGetter("TestObject.activityLoggedAttrGetter2");
TestObjectV8Internal::activityLoggedAttrGetter2AttributeGetterForMainWorld(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
@@ -2941,7 +2941,7 @@ static void activityLoggedInIsolatedWorldsAttrGetterAttributeGetterCallback(v8::
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMGetter");
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger())
- contextData->activityLogger()->log("TestObject.activityLoggedInIsolatedWorldsAttrGetter", 0, 0, "Getter");
+ contextData->activityLogger()->logGetter("TestObject.activityLoggedInIsolatedWorldsAttrGetter");
TestObjectV8Internal::activityLoggedInIsolatedWorldsAttrGetterAttributeGetter(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
@@ -4893,7 +4893,7 @@ static void activityLoggedMethod1MethodCallback(const v8::FunctionCallbackInfo<v
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
Vector<v8::Handle<v8::Value> > loggerArgs = toNativeArguments<v8::Handle<v8::Value> >(info, 0);
- contextData->activityLogger()->log("TestObject.activityLoggedMethod1", info.Length(), loggerArgs.data(), "Method");
+ contextData->activityLogger()->logMethod("TestObject.activityLoggedMethod1", info.Length(), loggerArgs.data());
}
TestObjectV8Internal::activityLoggedMethod1Method(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -4918,7 +4918,7 @@ static void activityLoggedMethod2MethodCallback(const v8::FunctionCallbackInfo<v
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
Vector<v8::Handle<v8::Value> > loggerArgs = toNativeArguments<v8::Handle<v8::Value> >(info, 0);
- contextData->activityLogger()->log("TestObject.activityLoggedMethod2", info.Length(), loggerArgs.data(), "Method");
+ contextData->activityLogger()->logMethod("TestObject.activityLoggedMethod2", info.Length(), loggerArgs.data());
}
TestObjectV8Internal::activityLoggedMethod2Method(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -4943,7 +4943,7 @@ static void activityLoggedMethod2MethodCallbackForMainWorld(const v8::FunctionCa
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
Vector<v8::Handle<v8::Value> > loggerArgs = toNativeArguments<v8::Handle<v8::Value> >(info, 0);
- contextData->activityLogger()->log("TestObject.activityLoggedMethod2", info.Length(), loggerArgs.data(), "Method");
+ contextData->activityLogger()->logMethod("TestObject.activityLoggedMethod2", info.Length(), loggerArgs.data());
}
TestObjectV8Internal::activityLoggedMethod2MethodForMainWorld(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -4968,7 +4968,7 @@ static void activityLoggedInIsolatedWorldMethodMethodCallback(const v8::Function
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
Vector<v8::Handle<v8::Value> > loggerArgs = toNativeArguments<v8::Handle<v8::Value> >(info, 0);
- contextData->activityLogger()->log("TestObject.activityLoggedInIsolatedWorldMethod", info.Length(), loggerArgs.data(), "Method");
+ contextData->activityLogger()->logMethod("TestObject.activityLoggedInIsolatedWorldMethod", info.Length(), loggerArgs.data());
}
TestObjectV8Internal::activityLoggedInIsolatedWorldMethodMethod(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -5060,7 +5060,7 @@ static void overloadedActivityLoggedMethodMethodCallback(const v8::FunctionCallb
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
Vector<v8::Handle<v8::Value> > loggerArgs = toNativeArguments<v8::Handle<v8::Value> >(info, 0);
- contextData->activityLogger()->log("TestObject.overloadedActivityLoggedMethod", info.Length(), loggerArgs.data(), "Method");
+ contextData->activityLogger()->logMethod("TestObject.overloadedActivityLoggedMethod", info.Length(), loggerArgs.data());
}
TestObjectV8Internal::overloadedActivityLoggedMethodMethod(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
@@ -5106,7 +5106,7 @@ static void overloadedActivityLoggedMethodMethodCallbackForMainWorld(const v8::F
V8PerContextData* contextData = V8PerContextData::from(info.GetIsolate()->GetCurrentContext());
if (contextData && contextData->activityLogger()) {
Vector<v8::Handle<v8::Value> > loggerArgs = toNativeArguments<v8::Handle<v8::Value> >(info, 0);
- contextData->activityLogger()->log("TestObject.overloadedActivityLoggedMethod", info.Length(), loggerArgs.data(), "Method");
+ contextData->activityLogger()->logMethod("TestObject.overloadedActivityLoggedMethod", info.Length(), loggerArgs.data());
}
TestObjectV8Internal::overloadedActivityLoggedMethodMethodForMainWorld(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
« Source/bindings/templates/attributes.cpp ('K') | « Source/bindings/templates/methods.cpp ('k') | Source/bindings/tests/results/V8TestObjectPython.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698