Source/bindings/v8/V8DOMActivityLogger.h - Issue 213783002: Pass current value of attributes to WebDOMActivityLogger Setter logs.

Side by Side Diff: Source/bindings/v8/V8DOMActivityLogger.h

Issue 213783002: Pass current value of attributes to WebDOMActivityLogger Setter logs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Working Version Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 23 matching lines...) Expand all Loading...
34 #include "wtf/PassOwnPtr.h"	34 #include "wtf/PassOwnPtr.h"

35 #include "wtf/text/WTFString.h"	35 #include "wtf/text/WTFString.h"

36 #include <v8.h>	36 #include <v8.h>

37	37

38 namespace WebCore {	38 namespace WebCore {

39	39

40 class V8DOMActivityLogger {	40 class V8DOMActivityLogger {

41 public:	41 public:

42 virtual ~V8DOMActivityLogger() { }	42 virtual ~V8DOMActivityLogger() { }

43	43

	44 // DEPRECATED: Only here for chrome compilation while the new patch goes thr ough.

44 virtual void log(const String& apiName, int argc, const v8::Handle<v8::Value >* argv, const String& extraInfo) { }	45 virtual void log(const String& apiName, int argc, const v8::Handle<v8::Value >* argv, const String& extraInfo) { }
	abarth-chromium 2014/04/22 23:35:51 Why is this needed to chrome compilation? Code ou Why is this needed to chrome compilation? Code outside of Blink should not depend directly on this header. Devlin 2014/04/23 01:10:03 Whoops! Meant to only leave in the one in public/ Show quoted text On 2014/04/22 23:35:51, abarth wrote: > Why is this needed to chrome compilation? Code outside of Blink should not > depend directly on this header. Whoops! Meant to only leave in the one in public/web/WebDOMActivityLogger.h. Removed.
45	46

	47 virtual void logGetter(const String& apiName) { }

	48 virtual void logSetter(const String& apiName, const v8::Handle<v8::Value>& n ewValue, const v8::Handle<v8::Value>& oldValue) { }

	49 virtual void logMethod(const String& apiName, int argc, const v8::Handle<v8: :Value>* argv) { }

	50

46 // Associates a logger with the world identified by worldId (worlId may be 0	51 // Associates a logger with the world identified by worldId (worlId may be 0

47 // identifying the main world).	52 // identifying the main world).

48 static void setActivityLogger(int worldId, PassOwnPtr<V8DOMActivityLogger>);	53 static void setActivityLogger(int worldId, PassOwnPtr<V8DOMActivityLogger>);

49 static V8DOMActivityLogger* activityLogger(int worldId);	54 static V8DOMActivityLogger* activityLogger(int worldId);

50 };	55 };

51	56

52 } // namespace WebCore	57 } // namespace WebCore

53	58

54 #endif // V8DOMActivityLogger_h	59 #endif // V8DOMActivityLogger_h

OLD	NEW