Pass current value of attributes to WebDOMActivityLogger Setter logs.

Source/bindings/IDLExtendedAttributes.txt

 #
 # This file describes all Blink IDL extended attributes and allowed values.
 # If any IDL file uses an extended attribute or values not listed below, the
 # build will fail.
 # If you would like to add a new extended attribute or value, please:
 #     (1) add the extended attribute or value to this file
 #     (2) add an explanation to the Blink IDL extended attributes document:
 #         http://www.chromium.org/blink/webidl/blink-idl-extended-attributes
 #     (3) add appropriate test cases to run-bindings-tests
 #
@@ skipping 16 matching lines @@
 #     - "Attr=*" means that Attr takes a required value, which can be
 #       arbitrary, and combinations thereof, e.g. [Attr=IndexedDB],
 #       [Attr=DeleteFunction], [Attr=X|Y].
 #     - "Attr=|*" means that Attr takes an optional value, which can be
 #       arbitrary, e.g. [Attr], [Attr=X].
 #     - "Attr=X|*" means that Attr takes an required value, which can be
 #       arbitrary, but that "X" is standard, e.g. [Attr=X], [Attr=Foo].
 #
 
 ActiveDOMObject
-ActivityLogging=ForAllWorlds|GetterForAllWorlds|SetterForAllWorlds|ForIsolatedWorlds|GetterForIsolatedWorlds|SetterForIsolatedWorlds
+ActivityLogging=ForAllWorlds|GetterForAllWorlds|SetterForAllWorlds|ForIsolatedWorlds|GetterForIsolatedWorlds|SetterForIsolatedWorlds|ForAllWorlsIncludeOldValueForSetter|SetterForAllWorldsIncludeOldValueForSetter|ForIsolatedWorldsIncludeOldValueForSetter|SetterForIsolatedWorldsIncludeOldValueForSetter

[Devlin, 2014/04/22 17:47:09]

This is getting a bit crazy - do we want to split these up?

[abarth-chromium, 2014/04/22 23:35:51]

Yeah, there seem to be several bits conflated here.  Can you split these up into
separate attributes?

[Devlin, 2014/04/23 01:10:03]

Done, per offline conversation, decided on one attribute each for the type of
activity, the worlds we log, and whether or not to include the old value.

As expected, this resulted in a bit of noise in the CL.  Apologies.

[Nils Barth (inactive), 2014/04/23 01:12:02]

Combinatorial explosion (>.<)
We can keep one attribute but have a list instead:
ActivityLogging=Getter|Setter|ForAllWorlds|ForIsolatedWorlds|OldValueForSetter

(I'm happy to do splitting in separate CL if that's desired.)
haraken@?

[Devlin, 2014/04/23 01:31:43]

Already fixed per Adam's comment.  Does the new format look okay?

[Nils Barth (inactive), 2014/04/23 03:04:42]

New format is fine, thanks!
Could you please post this in a separate CL, to simplify this CL?
(i.e., the extended attribute renaming, without adding new feature)

[Devlin, 2014/04/23 18:28:02]

Done, https://codereview.chromium.org/249833002/

[Nils Barth (inactive), 2014/04/24 01:00:41]

Thanks!

 CachedAttribute=*
 CallWith=ExecutionContext|ScriptState|NewScriptState|ScriptArguments|ActiveWindow|FirstWindow|ThisValue
 CheckSecurity=Frame|Node
 Clamp
 Conditional=*
 Constructor
 # FIXME: remove [ConstructorCallWith=Document], as can instead use
 # [ConstructorCallWith=ExecutionContext] + toDocument(executionContext)
 ConstructorCallWith=ExecutionContext|Document
 Custom=|Getter|Setter|LegacyCallAsFunction|ToV8|VisitDOMWrapper|Wrap|PropertyGetter|PropertyEnumerator|PropertyQuery
@@ skipping 40 matching lines @@
 SetWrapperReferenceTo=*
 SetterCallWith=ExecutionContext|ScriptState|ScriptArguments|ActiveWindow|FirstWindow
 SpecialWrapFor=*
 StrictTypeChecking
 TreatNullAs=NullString
 TreatReturnedNullStringAs=Null|Undefined
 TreatUndefinedAs=NullString
 URL
 Unforgeable
 WillBeGarbageCollected