Pass current value of attributes to WebDOMActivityLogger Setter logs.

public/web/WebDOMActivityLogger.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "../platform/WebCommon.h"
 #include "../platform/WebString.h"
 #include "../platform/WebURL.h"
 #include <v8.h>
 
 namespace blink {
 
 class WebDOMActivityLogger {
 public:
     virtual ~WebDOMActivityLogger() { }
+
+    // DEPRECATED: Only for chrome compilation during blink rolls.
     virtual void log(const WebString& apiName, int argc, const v8::Handle<v8::Value>* argv, const WebString& extraInfo, const WebURL& url, const WebString& title) { }

[abarth-chromium, 2014/04/24 14:48:22]

You should be able to remove this function.  Chromium shouldn't be using the
OVERRIDE keyword, which means it won't notice if this function disappears from
this base class.

[Devlin, 2014/04/24 16:40:35]

Chromium does use the OVERRIDE keyword.  Relevant instance here:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/renderer/ex...

+
+    virtual void logGetter(const WebString& apiName, const WebURL& url, const WebString& title) { }
+    virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value>& newValue, const WebURL& url, const WebString& title) { }
+    virtual void logSetter(const WebString& apiName, const v8::Handle<v8::Value>& newValue, const v8::Handle<v8::Value>& oldValue, const WebURL& url, const WebString& title) { }
+    virtual void logMethod(const WebString& apiName, int argc, const v8::Handle<v8::Value>* argv, const WebURL& url, const WebString& title) { }
 };
 
 // Checks if a logger already exists for the world identified
 // by worldId (worldId may be 0 identifying the main world).
 BLINK_EXPORT bool hasDOMActivityLogger(int worldId);
 
 // Checks if the provided logger is non-null and if so associates it
 // with the world identified by worldId (worldId may be 0 identifying the main world).
 BLINK_EXPORT void setDOMActivityLogger(int worldId, WebDOMActivityLogger*);
 
 } // namespace blink
 
 #endif