Pass current value of attributes to WebDOMActivityLogger Setter logs.

Source/bindings/scripts/v8_utilities.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 115 matching lines @@
 ################################################################################
 # Specific extended attributes
 ################################################################################
 
 # [ActivityLogging]
 def activity_logging_world_list(member, access_type=None):
     """Returns a set of world suffixes for which a definition member has activity logging, for specified access type.
 
     access_type can be 'Getter' or 'Setter' if only checking getting or setting.
     """
-    if 'ActivityLogging' not in member.extended_attributes:
+    if 'LogActivity' not in member.extended_attributes:

[Nils Barth (inactive), 2014/04/23 03:04:42]

BTW, could you add
extended_attributes = member.extended_attributes
here?
(As a rule we're using a local var if used 2+ times.)

[Devlin, 2014/04/23 18:28:02]

Done (in other cl).

         return set()
-    activity_logging = member.extended_attributes['ActivityLogging']
-    # [ActivityLogging=For*] (no prefix, starts with the worlds suffix) means
-    # "log for all use (method)/access (attribute)", otherwise check that value
-    # agrees with specified access_type (Getter/Setter).
-    has_logging = (activity_logging.startswith('For') or
-                   (access_type and activity_logging.startswith(access_type)))
-    if not has_logging:
+    log_activity = member.extended_attributes['LogActivity']
+    if (log_activity == 'GetterOnly' and access_type != 'Getter') or (log_activity == 'SetterOnly' and access_type != 'Setter'):

[Nils Barth (inactive), 2014/04/23 03:04:42]

This could be:
if log_activity and not log_activity.startswith(access_type):

(changing default to access_type='')
If we remove the 'Only', this could simply be:
if log_activity and log_activity != access_type:

[Devlin, 2014/04/23 18:28:02]

Done (in other cl).  My inclination is to keep GetterOnly/SetterOnly, because it
makes it more clear that they are values which limit (rather than extend) the
default behavior.  But I don't feel strongly, so if 'Getter'/'Setter' is
preferred, happy to do so. :)

[Nils Barth (inactive), 2014/04/24 01:00:41]

That's fine, and agreed that explicit is better here.
Clearer IDL files at v. minor Python complexity expense is the right trade-off.

         return set()
+
     includes.add('bindings/v8/V8DOMActivityLogger.h')
-    if activity_logging.endswith('ForIsolatedWorlds'):
-        return set([''])
-    return set(['', 'ForMainWorld'])  # endswith('ForAllWorlds')
+    # At minimum, include isolated worlds.
+    world_list = ['']
+    if 'LogAllWorlds' in member.extended_attributes:
+        world_list.append('ForMainWorld')
+    return world_list

[Nils Barth (inactive), 2014/04/23 03:04:42]

return set(world_list)
I'd tend to prefer avoiding mutation:
if 'LogAllWorlds' in extended_attributes:
    return set(['', 'ForMainWorld'])
return set([''])  # At minimum, include isolated worlds.

[Devlin, 2014/04/23 18:28:02]

Done (in other cl).

 
 
 # [CallWith]
 CALL_WITH_ARGUMENTS = {
     'ScriptState': 'state',
     'NewScriptState': 'state',
     'ExecutionContext': 'scriptContext',
     'ScriptArguments': 'scriptArguments.release()',
     'ActiveWindow': 'callingDOMWindow(info.GetIsolate())',
     'FirstWindow': 'enteredDOMWindow(info.GetIsolate())',
@@ skipping 84 matching lines @@
 
     The returned function checks if a method/attribute is enabled.
     Given extended attribute RuntimeEnabled=FeatureName, return:
         RuntimeEnabledFeatures::{featureName}Enabled
     """
     extended_attributes = definition_or_member.extended_attributes
     if 'RuntimeEnabled' not in extended_attributes:
         return None
     feature_name = extended_attributes['RuntimeEnabled']
     return 'RuntimeEnabledFeatures::%sEnabled' % uncapitalize(feature_name)