Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 2137803002: Remove unnecessary pass statements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 _winreg.CloseKey(hkey) 118 _winreg.CloseKey(hkey)
119 119
120 # In order to keep multiple checkouts from stepping on each other, w e simply check that an 120 # In order to keep multiple checkouts from stepping on each other, w e simply check that an
121 # existing entry points to a valid path and has the right command li ne. 121 # existing entry points to a valid path and has the right command li ne.
122 if len(args) == 2 and self._filesystem.exists(args[0]) and args[0].e ndswith('perl.exe') and args[1] == '-wT': 122 if len(args) == 2 and self._filesystem.exists(args[0]) and args[0].e ndswith('perl.exe') and args[1] == '-wT':
123 return True 123 return True
124 except WindowsError as e: 124 except WindowsError as e:
125 if e.errno != errno.ENOENT: 125 if e.errno != errno.ENOENT:
126 raise e 126 raise e
127 # The key simply probably doesn't exist. 127 # The key simply probably doesn't exist.
128 pass
129 128
130 # Note that we write to HKCU so that we don't need privileged access 129 # Note that we write to HKCU so that we don't need privileged access
131 # to the registry, and that will get reflected in HKCR when it is read, above. 130 # to the registry, and that will get reflected in HKCR when it is read, above.
132 cmdline = self.path_from_chromium_base('third_party', 'perl', 'perl', 'b in', 'perl.exe') + ' -wT' 131 cmdline = self.path_from_chromium_base('third_party', 'perl', 'perl', 'b in', 'perl.exe') + ' -wT'
133 hkey = _winreg.CreateKeyEx(_winreg.HKEY_CURRENT_USER, 'Software\\Classes \\' + sub_key, 0, _winreg.KEY_WRITE) 132 hkey = _winreg.CreateKeyEx(_winreg.HKEY_CURRENT_USER, 'Software\\Classes \\' + sub_key, 0, _winreg.KEY_WRITE)
134 _winreg.SetValue(hkey, '', _winreg.REG_SZ, cmdline) 133 _winreg.SetValue(hkey, '', _winreg.REG_SZ, cmdline)
135 _winreg.CloseKey(hkey) 134 _winreg.CloseKey(hkey)
136 return True 135 return True
137 136
138 def setup_test_run(self): 137 def setup_test_run(self):
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 return result 240 return result
242 241
243 def look_for_new_crash_logs(self, crashed_processes, start_time): 242 def look_for_new_crash_logs(self, crashed_processes, start_time):
244 if self.get_option('disable_breakpad'): 243 if self.get_option('disable_breakpad'):
245 return None 244 return None
246 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time) 245 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time)
247 246
248 def clobber_old_port_specific_results(self): 247 def clobber_old_port_specific_results(self):
249 if not self.get_option('disable_breakpad'): 248 if not self.get_option('disable_breakpad'):
250 self._dump_reader.clobber_old_results() 249 self._dump_reader.clobber_old_results()
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698