Support POST in browser navaigation.

chrome/browser/ui/browser_navigator_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_navigator_browsertest.h"
 
+#include <string>
+
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
+#include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/chrome_pages.h"
@@ skipping 36 matching lines @@
 GURL ShortenUberURL(const GURL& url) {
   std::string url_string = url.spec();
   const std::string long_prefix = "chrome://chrome/";
   const std::string short_prefix = "chrome://";
   if (url_string.find(long_prefix) != 0)
     return url;
   url_string.replace(0, long_prefix.length(), short_prefix);
   return GURL(url_string);
 }
 
-} // namespace
+}  // namespace
 
 chrome::NavigateParams BrowserNavigatorTest::MakeNavigateParams() const {
   return MakeNavigateParams(browser());
 }
 
 chrome::NavigateParams BrowserNavigatorTest::MakeNavigateParams(
     Browser* browser) const {
   chrome::NavigateParams params(browser, GetGoogleURL(),
                                 content::PAGE_TRANSITION_LINK);
   params.window_action = chrome::NavigateParams::SHOW_WINDOW;
@@ skipping 1208 matching lines @@
                                            content::PAGE_TRANSITION_LINK);
   ui_test_utils::NavigateToURL(&viewsource_params);
 
   chrome::NavigateParams singleton_params(browser(),
                                           GURL(chrome::kChromeUIVersionURL),
                                           content::PAGE_TRANSITION_LINK);
   singleton_params.disposition = SINGLETON_TAB;
   EXPECT_EQ(-1, chrome::GetIndexOfSingletonTab(&singleton_params));
 }
 
-} // namespace
+// This test verifies that navigation can send request using POST.

[Charlie Reis, 2013/08/02 23:53:43]

nit: s/navigation/browser initiated navigations/
s/request/requests/

[Johnny(Jianning) Ding, 2013/08/03 01:11:17]

Done.

+IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, SendRequestUsingPOST) {
+  const char kExpectedTitle[] = "PASSED!";
+  const char kEchoTitleCommand[] = "echotitle";
+  // Uses a test sever to verify POST request.
+  ASSERT_TRUE(test_server()->Start());
+
+  // Open POST request in new foreground tab.
+  chrome::NavigateParams p(MakeNavigateParams());

[Charlie Reis, 2013/08/02 23:53:43]

nit: s/p/params/

[Johnny(Jianning) Ding, 2013/08/03 01:11:17]

Done.

+  p.disposition = NEW_FOREGROUND_TAB;
+  p.url = test_server()->GetURL(kEchoTitleCommand);
+  LOG(INFO) << p.url.spec();

[Charlie Reis, 2013/08/02 23:53:43]

Probably best to remove this log statement unless there's a reason to keep it.

[Johnny(Jianning) Ding, 2013/08/03 01:11:17]

Done.

+  p.uses_post = true;
+  std::string post_data = kExpectedTitle;
+  p.browser_initiated_post_data =
+      base::RefCountedString::TakeString(&post_data);
+
+  string16 expected_title(base::ASCIIToUTF16(kExpectedTitle));
+  ui_test_utils::NavigateToURL(&p);
+  ASSERT_TRUE(p.target_contents != NULL);

[Charlie Reis, 2013/08/02 23:53:43]

nit: Don't need != NULL

[Johnny(Jianning) Ding, 2013/08/03 01:11:17]

Done.

+  // The title should match the post data.
+  ASSERT_EQ(expected_title, p.target_contents->GetTitle());
+
+  // Navigate() should have opened the contents in new foreground tab in the
+  // current Browser.
+  EXPECT_EQ(browser(), p.browser);
+  EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents(),
+            p.target_contents);
+  // We should have one window, with one tab.
+  EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
+  EXPECT_EQ(2, browser()->tab_strip_model()->count());
+}
+
+}  // namespace