Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing the code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
index 4013efa2e1199fc65b60a2dbc35cd042f6941300..29f40d65a207c8c2bbc34baaa0f575373f310d27 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
@@ -39,7 +39,7 @@ WebInspector.RuntimeModel = function(target)
this._agent = target.runtimeAgent();
this.target().registerRuntimeDispatcher(new WebInspector.RuntimeDispatcher(this));
- if (target.hasJSContext())
+ if (target.hasJSCapability())
this._agent.enable();
/**
* @type {!Object.<number, !WebInspector.ExecutionContext>}
@@ -442,9 +442,9 @@ WebInspector.ExecutionContext.comparator = function(a, b)
*/
function targetWeight(target)
{
- if (target.isPage())
+ if (target.hasBrowserCapability())
return 3;
- if (target.isDedicatedWorker())
+ if (target.hasJSCapability())
return 2;
return 1;
}
@@ -869,11 +869,11 @@ WebInspector.EventListener.prototype = {
if (!this._removeFunction)
return Promise.resolve();
return this._removeFunction.callFunctionPromise(callCustomRemove, [
- WebInspector.RemoteObject.toCallArgument(this._type),
- WebInspector.RemoteObject.toCallArgument(this._originalHandler),
- WebInspector.RemoteObject.toCallArgument(this._useCapture),
- WebInspector.RemoteObject.toCallArgument(this._passive),
- ]).then(() => undefined);
+ WebInspector.RemoteObject.toCallArgument(this._type),
+ WebInspector.RemoteObject.toCallArgument(this._originalHandler),
+ WebInspector.RemoteObject.toCallArgument(this._useCapture),
+ WebInspector.RemoteObject.toCallArgument(this._passive),
+ ]).then(() => undefined);
/**
* @param {string} type

Powered by Google App Engine
This is Rietveld 408576698