third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing the code review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

index f59a6b0d20f6df0bd195612973bb19b63c92062c..0c02bc56ba0fe6659b1ff70fc669603d7d915269 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

@@ -532,7 +532,7 @@ WebInspector.RemoteObjectImpl.prototype = {

function eventListeners(fulfill, reject)

{

- if (!this.target().isPage()) {

+ if (!this.target().hasBrowserCapability()) {

// TODO(kozyatinskiy): figure out how this should work for |window| when there is no DOMDebugger.

fulfill([]);

return;