Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing the code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
index 58c70a5544f2f9ae7c61bdf43c778ad8a61c5809..e5a1165cb330efde12a9ebbff1b8f5fc81d78abd 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js
@@ -35,12 +35,14 @@ InspectorTest.createWorkspace = function(ignoreEvents)
InspectorTest._mockTargetId = 1;
-InspectorTest.createMockTarget = function(id, debuggerModelConstructor, targetType)
+InspectorTest.createMockTarget = function(id, debuggerModelConstructor, capabilities)
{
var MockTarget = function(name, connection, callback)
{
- var type = typeof targetType === "undefined" ? WebInspector.Target.Type.Page : targetType;
- WebInspector.Target.call(this, InspectorTest.testTargetManager, name, type, connection, null, callback);
+ var caps = typeof capabilities === "undefined" ?
dgozman 2016/07/13 00:08:29 No abbreviations.
eostroukhov-old 2016/07/13 00:36:29 Done.
+ WebInspector.Target.Capability.Browser | WebInspector.Target.Capability.JS | WebInspector.Target.Capability.Network | WebInspector.Target.Capability.Worker :
+ capabilities;
+ WebInspector.Target.call(this, InspectorTest.testTargetManager, name, caps, connection, null, callback);
this.consoleModel = new WebInspector.ConsoleModel(this);
this.networkManager = new WebInspector.NetworkManager(this);
this.resourceTreeModel = new WebInspector.ResourceTreeModel(this);

Powered by Google App Engine
This is Rietveld 408576698