Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [DevTools] Replace target type with capabilities Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
index 8243eaed0b38cb110536c32a511f2a509e398b3d..05df60ec588979bcebb775928b2af334206d03f0 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
@@ -21,7 +21,7 @@ WebInspector.XHRBreakpointsSidebarPane = function()
this.emptyElement.addEventListener("contextmenu", this._emptyElementContextMenu.bind(this), true);
- WebInspector.targetManager.observeTargets(this, WebInspector.Target.Type.Page);
+ WebInspector.targetManager.observeTargets(this, WebInspector.Target.Capabilities.BROWSER_DOMAINS);
}
WebInspector.XHRBreakpointsSidebarPane.prototype = {
@@ -139,12 +139,12 @@ WebInspector.XHRBreakpointsSidebarPane.prototype = {
*/
_updateBreakpointOnTarget: function(url, enable, target)
{
- var targets = target ? [target] : WebInspector.targetManager.targets(WebInspector.Target.Type.Page);
- for (var i = 0; i < targets.length; ++i) {
+ var targets = target ? [target] : WebInspector.targetManager.targets();
dgozman 2016/07/12 00:34:11 browser domains
eostroukhov-old 2016/07/12 21:46:16 Done.
+ for (var t of targets) {
if (enable)
- targets[i].domdebuggerAgent().setXHRBreakpoint(url);
+ t.domdebuggerAgent().setXHRBreakpoint(url);
else
- targets[i].domdebuggerAgent().removeXHRBreakpoint(url);
+ t.domdebuggerAgent().removeXHRBreakpoint(url);
}
},

Powered by Google App Engine
This is Rietveld 408576698