third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [DevTools] Replace target type with capabilities Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/Target.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/Target.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

index ab0e7d545cba42fc50eb8577e20fa6893cfdd3d6..8596ac6ab7201f3d1ddcd906d563e92a2cd959ae 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

@@ -435,7 +435,8 @@ WebInspector.ServiceWorker = function(manager, workerId, url, versionId)

this._scope = parsedURL.host + parsedURL.folderPathComponents;

this._manager._workers.set(workerId, this);

- this._target = WebInspector.targetManager.createTarget(this._name, WebInspector.Target.Type.ServiceWorker, this._connection, manager.target());

+ var caps = WebInspector.Target.Capabilities.NETWORK_DOMAINS | WebInspector.Target.Capabilities.WORKER_DOMAINS;

dgozman 2016/07/12 00:34:11 No abbreviations.

eostroukhov-old 2016/07/12 21:46:15 Done.

+ this._target = WebInspector.targetManager.createTarget(this._name, caps, this._connection, manager.target());

this._target[WebInspector.ServiceWorker.Symbol] = this;

this._manager.dispatchEventToListeners(WebInspector.ServiceWorkerManager.Events.WorkersUpdated);

this._target.runtimeAgent().run();