third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js - Issue 2137773002: [DevTools] Replace the target type with capabilities

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [DevTools] Replace target type with capabilities Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js ('K') | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html ('k') | third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js » ('j') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js b/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

index 4d4dcca0215b04030f4e0149b120f78ce3fab1ee..0f6231874b4e9a78f4723f8221d79cb78635962b 100644

--- a/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js

@@ -202,10 +202,12 @@ WebInspector.AnimationModel._symbol = Symbol("AnimationModel");

/**

* @param {!WebInspector.Target} target

- * @return {!WebInspector.AnimationModel}

+ * @return {?WebInspector.AnimationModel}

WebInspector.AnimationModel.fromTarget = function(target)

{

+ if (!target.hasBrowserDomains())

+ return null;

if (!target[WebInspector.AnimationModel._symbol])

target[WebInspector.AnimationModel._symbol] = new WebInspector.AnimationModel(target);