Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing the code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 * @override 80 * @override
81 * @param {!WebInspector.Target} target 81 * @param {!WebInspector.Target} target
82 */ 82 */
83 targetRemoved: function(target) 83 targetRemoved: function(target)
84 { 84 {
85 this._updateLoadButtonLayout(); 85 this._updateLoadButtonLayout();
86 }, 86 },
87 87
88 _updateLoadButtonLayout: function() 88 _updateLoadButtonLayout: function()
89 { 89 {
90 this._loadButton.classList.toggle("multi-target", WebInspector.targetMan ager.targetsWithJSContext().length > 1); 90 this._loadButton.classList.toggle("multi-target", WebInspector.targetMan ager.hasTargets(WebInspector.Target.Capability.JS));
dgozman 2016/07/13 00:08:29 .targets(WebInspector.Target.Capability.JS).length
eostroukhov-old 2016/07/13 00:36:29 Oops. Thanks!
91 }, 91 },
92 92
93 /** 93 /**
94 * @param {!WebInspector.ProfileType} profileType 94 * @param {!WebInspector.ProfileType} profileType
95 */ 95 */
96 addProfileType: function(profileType) 96 addProfileType: function(profileType)
97 { 97 {
98 var descriptionElement = this._innerContentElement.createChild("h1"); 98 var descriptionElement = this._innerContentElement.createChild("h1");
99 descriptionElement.textContent = profileType.description; 99 descriptionElement.textContent = profileType.description;
100 var decorationElement = profileType.decorationElement(); 100 var decorationElement = profileType.decorationElement();
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 }, 251 },
252 252
253 profileFinished: function() 253 profileFinished: function()
254 { 254 {
255 this._isProfiling = false; 255 this._isProfiling = false;
256 this._updateControls(); 256 this._updateControls();
257 }, 257 },
258 258
259 __proto__: WebInspector.ProfileLauncherView.prototype 259 __proto__: WebInspector.ProfileLauncherView.prototype
260 } 260 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698