Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing the code review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 return 16; 259 return 16;
260 }, 260 },
261 261
262 /** 262 /**
263 * @override 263 * @override
264 * @param {!WebInspector.Target} target 264 * @param {!WebInspector.Target} target
265 */ 265 */
266 targetAdded: function(target) 266 targetAdded: function(target)
267 { 267 {
268 this._viewport.invalidate(); 268 this._viewport.invalidate();
269 if (WebInspector.targetManager.targets().length > 1 && WebInspector.targ etManager.mainTarget().isPage()) 269 var shouldShowCheck = WebInspector.targetManager.targets(WebInspector.Ta rget.Capability.Browser).length > 1;
dgozman 2016/07/13 00:08:29 Capability.Browser -> Capability.JS
dgozman 2016/07/13 00:08:29 haveMultipleContexts
eostroukhov-old 2016/07/13 00:36:29 Done.
eostroukhov-old 2016/07/13 00:36:29 Done.
dgozman 2016/07/13 00:41:52 Not done :-)
270 this._showAllMessagesCheckbox.element.classList.toggle("hidden", fal se); 270 this._showAllMessagesCheckbox.element.classList.toggle("hidden", shouldS howCheck);
dgozman 2016/07/13 00:08:29 !haveMultipleContexts
eostroukhov-old 2016/07/13 00:36:29 Done.
271 }, 271 },
272 272
273 /** 273 /**
274 * @override 274 * @override
275 * @param {!WebInspector.Target} target 275 * @param {!WebInspector.Target} target
276 */ 276 */
277 targetRemoved: function(target) 277 targetRemoved: function(target)
278 { 278 {
279 }, 279 },
280 280
(...skipping 1061 matching lines...) Expand 10 before | Expand all | Expand 10 after
1342 return true; 1342 return true;
1343 } 1343 }
1344 return false; 1344 return false;
1345 } 1345 }
1346 } 1346 }
1347 1347
1348 /** 1348 /**
1349 * @typedef {{messageIndex: number, matchIndex: number}} 1349 * @typedef {{messageIndex: number, matchIndex: number}}
1350 */ 1350 */
1351 WebInspector.ConsoleView.RegexMatchRange; 1351 WebInspector.ConsoleView.RegexMatchRange;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698