Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2137773002: [DevTools] Replace the target type with capabilities (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.BreakpointsSidebarPaneBase} 7 * @extends {WebInspector.BreakpointsSidebarPaneBase}
8 * @implements {WebInspector.TargetManager.Observer} 8 * @implements {WebInspector.TargetManager.Observer}
9 */ 9 */
10 WebInspector.XHRBreakpointsSidebarPane = function() 10 WebInspector.XHRBreakpointsSidebarPane = function()
11 { 11 {
12 WebInspector.BreakpointsSidebarPaneBase.call(this, WebInspector.UIString("XH R Breakpoints")); 12 WebInspector.BreakpointsSidebarPaneBase.call(this, WebInspector.UIString("XH R Breakpoints"));
13 this._xhrBreakpointsSetting = WebInspector.settings.createLocalSetting("xhrB reakpoints", []); 13 this._xhrBreakpointsSetting = WebInspector.settings.createLocalSetting("xhrB reakpoints", []);
14 14
15 /** @type {!Map.<string, !Element>} */ 15 /** @type {!Map.<string, !Element>} */
16 this._breakpointElements = new Map(); 16 this._breakpointElements = new Map();
17 17
18 var addButton = new WebInspector.ToolbarButton(WebInspector.UIString("Add br eakpoint"), "add-toolbar-item"); 18 var addButton = new WebInspector.ToolbarButton(WebInspector.UIString("Add br eakpoint"), "add-toolbar-item");
19 addButton.addEventListener("click", this._addButtonClicked.bind(this)); 19 addButton.addEventListener("click", this._addButtonClicked.bind(this));
20 this.toolbar().appendToolbarItem(addButton); 20 this.toolbar().appendToolbarItem(addButton);
21 21
22 this.emptyElement.addEventListener("contextmenu", this._emptyElementContextM enu.bind(this), true); 22 this.emptyElement.addEventListener("contextmenu", this._emptyElementContextM enu.bind(this), true);
23 23
24 WebInspector.targetManager.observeTargets(this, WebInspector.Target.Type.Pag e); 24 WebInspector.targetManager.observeTargets(this, WebInspector.Target.Capabili ty.Browser);
25 } 25 }
26 26
27 WebInspector.XHRBreakpointsSidebarPane.prototype = { 27 WebInspector.XHRBreakpointsSidebarPane.prototype = {
28 /** 28 /**
29 * @override 29 * @override
30 * @param {!WebInspector.Target} target 30 * @param {!WebInspector.Target} target
31 */ 31 */
32 targetAdded: function(target) 32 targetAdded: function(target)
33 { 33 {
34 this._restoreBreakpoints(target); 34 this._restoreBreakpoints(target);
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 this._updateBreakpointOnTarget(url, false, target); 132 this._updateBreakpointOnTarget(url, false, target);
133 }, 133 },
134 134
135 /** 135 /**
136 * @param {string} url 136 * @param {string} url
137 * @param {boolean} enable 137 * @param {boolean} enable
138 * @param {!WebInspector.Target=} target 138 * @param {!WebInspector.Target=} target
139 */ 139 */
140 _updateBreakpointOnTarget: function(url, enable, target) 140 _updateBreakpointOnTarget: function(url, enable, target)
141 { 141 {
142 var targets = target ? [target] : WebInspector.targetManager.targets(Web Inspector.Target.Type.Page); 142 var targets = target ? [target] : WebInspector.targetManager.targets(Web Inspector.Target.Capability.Browser);
143 for (var i = 0; i < targets.length; ++i) { 143 for (target of targets) {
144 if (enable) 144 if (enable)
145 targets[i].domdebuggerAgent().setXHRBreakpoint(url); 145 target.domdebuggerAgent().setXHRBreakpoint(url);
146 else 146 else
147 targets[i].domdebuggerAgent().removeXHRBreakpoint(url); 147 target.domdebuggerAgent().removeXHRBreakpoint(url);
148 } 148 }
149 }, 149 },
150 150
151 _contextMenu: function(url, event) 151 _contextMenu: function(url, event)
152 { 152 {
153 var contextMenu = new WebInspector.ContextMenu(event); 153 var contextMenu = new WebInspector.ContextMenu(event);
154 154
155 /** 155 /**
156 * @this {WebInspector.XHRBreakpointsSidebarPane} 156 * @this {WebInspector.XHRBreakpointsSidebarPane}
157 */ 157 */
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 var breakpoints = this._xhrBreakpointsSetting.get(); 246 var breakpoints = this._xhrBreakpointsSetting.get();
247 for (var i = 0; i < breakpoints.length; ++i) { 247 for (var i = 0; i < breakpoints.length; ++i) {
248 var breakpoint = breakpoints[i]; 248 var breakpoint = breakpoints[i];
249 if (breakpoint && typeof breakpoint.url === "string") 249 if (breakpoint && typeof breakpoint.url === "string")
250 this._setBreakpoint(breakpoint.url, breakpoint.enabled, target); 250 this._setBreakpoint(breakpoint.url, breakpoint.enabled, target);
251 } 251 }
252 }, 252 },
253 253
254 __proto__: WebInspector.BreakpointsSidebarPaneBase.prototype 254 __proto__: WebInspector.BreakpointsSidebarPaneBase.prototype
255 } 255 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698