Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2703)

Unified Diff: chrome/installer/mac/app/BUILD.gn

Issue 2137743002: Added test files for SystemInfo.m and OmahaXMLRequest.m. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comments & made progress on roughly half of Mark's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mac/BUILD.gn ('k') | chrome/installer/mac/app/testing/OmahaXMLRequest_test.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mac/app/BUILD.gn
diff --git a/chrome/installer/mac/app/BUILD.gn b/chrome/installer/mac/app/BUILD.gn
index aa2123f2c6ce5a2b5d1ae8e5cdcae118c36435af..efeecdd3d560943e7a39d24c16a89d7b19b832c3 100644
--- a/chrome/installer/mac/app/BUILD.gn
+++ b/chrome/installer/mac/app/BUILD.gn
@@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-executable("downloader") {
+static_library("mac_installer_base") {
sources = [
"DownloadDelegate.m",
"Downloader.m",
@@ -11,7 +11,29 @@ executable("downloader") {
"OmahaXMLParser.m",
"OmahaXMLRequest.m",
"SystemInfo.m",
+ ]
+}
+
+executable("mac_installer") {
+ sources = [
"main.m",
]
+ deps = [
+ ":mac_installer_base",
+ ]
+ libs = [ "Foundation.framework" ]
+}
+
+executable("mac_installer_test") {
Mark Mentovai 2016/07/19 21:03:49 OK! Got a better answer here. This should use the
Anna Zeng 2016/07/22 16:58:02 Done.
+ testonly = true
+ sources = [
+ # "//testing/gtest/src/gtest_main.cc",
+ "testing/OmahaXMLRequest_test.mm",
+ "testing/SystemInfo_test.mm",
+ ]
+ deps = [
+ ":mac_installer_base",
+ "//testing/gtest:gtest_main",
Mark Mentovai 2016/07/19 21:03:49 And the answer on this one is to use //base/test:r
Anna Zeng 2016/07/22 16:58:02 Done.
+ ]
libs = [ "Foundation.framework" ]
}
« no previous file with comments | « chrome/installer/mac/BUILD.gn ('k') | chrome/installer/mac/app/testing/OmahaXMLRequest_test.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698