Added test files for SystemInfo.m and OmahaXMLRequest.m.

chrome/installer/mac/app/testing/SystemInfo_test.mm

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "../SystemInfo.h"

[Mark Mentovai, 2016/07/15 21:56:09]

#import

[Anna Zeng, 2016/07/22 16:58:02]

Done.

+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+class SystemInfoTest : public ::testing::Test {};

[Mark Mentovai, 2016/07/15 21:56:09]

Don’t need this at all. You haven’t used it, since you’ve only got TEST, not
TEST_F.

[Anna Zeng, 2016/07/22 16:58:02]

Done.

+
+TEST(SystemInfoTest, getArchDoesNotReturnNil) {
+  EXPECT_NE([SystemInfo getArch], nil);

[Mark Mentovai, 2016/07/15 21:56:09]

EXPECT_TRUE is fine.

[Anna Zeng, 2016/07/22 16:58:02]

Done.

+}
+
+TEST(SystemInfoTest, getArchReturnsAString) {
+  EXPECT_TRUE([[SystemInfo getArch] isKindOfClass:[NSString class]]);
+}
+
+TEST(SystemInfoTest, getArchReturnsAtLeastThreeCharacters) {
+  EXPECT_GE((int)[[SystemInfo getArch] length], 3);

[Mark Mentovai, 2016/07/15 21:56:09]

You’ve got three tests where I think that one will do:

 - getArchReturnsAtLeastThreeCharacters implies that the arch was a string, so
getArchReturnsAString isn’t necessary
 - getArchReturnsAString implies that the return was non-nil, so
getArchReturnsAString isn’t necessary

Actually, I think we should nail the test down a bit harder. We know we only
want to see x86_64h or i486 here (ugh). So let’s just test that this returns one
of those things. We don’t need class tests or length tests or non-nil checks.
EXPECT_TRUE([arch isEqualToString:@"i486"] || [arch
isEqualToString:@"x86_64h"]);. If you’re compelled to, you can stick this in an
#if defined(__x86_64__) and #error on other architectures, the same as in the
.mm file.

So you’ll be writing less code but actually testing more. Efficiency!

[Anna Zeng, 2016/07/22 01:45:37]

So... you mean that we want the code to work ONLY on i486 or x86_64, and to
throw an error for all other architectures? Are... you sure?

[Mark Mentovai, 2016/07/22 13:55:49]

Remember the macro that we stuck at the top of SystemInfo.h? If we ever did find
ourselves building for a non-__x86_64__ system, the .m file would #error too,
and if we fixed that, we’d also want to fix this test.

We know that i486 and x86_64h are the only things that the API we’re using can
return now. We also know that it’s quirky, because i486 is kind of a weird thing
to return on a 64-bit system to begin with. So we’d just be duplicating that in
our test, basically saying “we know that these are the only two things we’ve
ever seen that weird call return, and if it ever starts returning something
else, we probably want to verify that it’s correct.”

[Anna Zeng, 2016/07/22 16:58:02]

Done.

+}
+
+TEST(SystemInfoTest, getOSVersionDoesNotReturnNil) {
+  EXPECT_NE([SystemInfo getOSVersion], nil);
+}
+
+TEST(SystemInfoTest, getOSVersionReturnsAString) {
+  EXPECT_TRUE([[SystemInfo getOSVersion] isKindOfClass:[NSString class]]);
+}
+
+TEST(SystemInfoTest, getOSVersionReturnsAtLeastThreeCharacters) {
+  EXPECT_GE((int)[[SystemInfo getOSVersion] length], 3);
+}
+
+TEST(SystemInfoTest, getOSVersionContainsPeriodDelimiters) {
+  EXPECT_NE([[SystemInfo getOSVersion] rangeOfString:@"."
+                                             options:NSCaseInsensitiveSearch]
+                .location,
+            (unsigned)NSNotFound);
+}
+
+TEST(SystemInfoTest, getOSVersionReturnsNumbers) {

[Mark Mentovai, 2016/07/15 21:56:09]

Similar here. Let’s just make sure that the format is "10.digits.digits".
NSRegularExpression might be the easiest way to do this, actually. Again,
probably only this needs one TEST to cover getOSVersion.

If you want to get fancy, make sure that the runs of digits don’t begin with
zero unless there’s only a single digit in there (as in 10.11.0).

[Anna Zeng, 2016/07/22 16:58:02]

Done.

+  NSArray* substrings =
+      [[SystemInfo getOSVersion] componentsSeparatedByString:@"."];
+  for (NSString* s in substrings) {
+    EXPECT_TRUE(([s intValue] != 0) || [s isEqualToString:@"0"]);
+  }
+}
+
+}  // namespace