Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: chrome/installer/mac/app/BUILD.gn

Issue 2137743002: Added test files for SystemInfo.m and OmahaXMLRequest.m. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Last change before LGTM! Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/installer/mac/app/testing/OmahaXMLRequest_test.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni")
6
5 static_library("mac_installer_base") { 7 static_library("mac_installer_base") {
6 sources = [ 8 sources = [
7 "Downloader.m", 9 "Downloader.m",
8 "MainDelegate.m", 10 "MainDelegate.m",
9 "NetworkCommunication.m", 11 "NetworkCommunication.m",
10 "OmahaCommunication.m", 12 "OmahaCommunication.m",
11 "OmahaXMLParser.m", 13 "OmahaXMLParser.m",
12 "OmahaXMLRequest.m", 14 "OmahaXMLRequest.m",
13 "SystemInfo.m", 15 "SystemInfo.m",
14 ] 16 ]
15 } 17 }
16 18
17 executable("mac_installer") { 19 executable("mac_installer") {
18 sources = [ 20 sources = [
19 "main.m", 21 "main.m",
20 ] 22 ]
21 deps = [ 23 deps = [
22 ":mac_installer_base", 24 ":mac_installer_base",
23 ] 25 ]
24 libs = [ 26 libs = [ "Foundation.framework" ]
25 "AppKit.framework", 27 }
26 "CoreFoundation.framework", 28
27 "Foundation.framework", 29 test("mac_installer_test") {
30 testonly = true
31 sources = [
32 "testing/OmahaXMLRequest_test.mm",
33 "testing/SystemInfo_test.mm",
28 ] 34 ]
35 deps = [
Mark Mentovai 2016/07/22 19:19:25 The trybot output sounds like it’s asking you to d
36 ":mac_installer_base",
37 "//base/test:run_all_unittests",
38 ]
39 libs = [ "Foundation.framework" ]
29 } 40 }
OLDNEW
« no previous file with comments | « no previous file | chrome/installer/mac/app/testing/OmahaXMLRequest_test.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698