Added test files for SystemInfo.m and OmahaXMLRequest.m.

chrome/installer/mac/app/testing/OmahaXMLRequest_test.mm

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/mac/scoped_nsobject.h"
+#include "base/macros.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+#import "chrome/installer/mac/app/OmahaXMLRequest.h"

[Mark Mentovai, 2016/07/22 18:03:24]

This should be the _first_ #import in the file. When you’re testing something,
#import/#include the thing that it’s testing first, above everything else (even
system includes).

The rationale for our #include rules is in the style guide at
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes.
Note that the example there says “In dir/foo.cc or dir/foo_test.cc, whose main
purpose is to implement or test the stuff in dir2/foo2.h”. It applies to the
test code too!

+
+namespace {
+
+TEST(OmahaXMLRequestTest, CreateReturnsValidXML) {
+  base::scoped_nsobject<NSXMLDocument> xml_body_(
+      [OmahaXMLRequest createXMLRequestBody]);
+  ASSERT_TRUE(xml_body_);
+
+  NSString* requestDTDLocation =
+      [[[NSFileManager defaultManager] currentDirectoryPath]
+          stringByAppendingString:@"/testing/requestCheck.dtd"];
+  NSData* requestDTDData = [NSData dataWithContentsOfFile:requestDTDLocation];
+  NSError* error;
+  NSXMLDTD* requestXMLChecker =
+      [[NSXMLDTD alloc] initWithData:requestDTDData options:0 error:&error];
+  [requestXMLChecker setName:@"request"];
+  [xml_body_ setDTD:requestXMLChecker];
+  EXPECT_TRUE([xml_body_ validateAndReturnError:&error]);
+}
+
+}  // namespace