Source/core/html/HTMLSelectElement.h - Issue 213773003: select.add() should support optgroup adding and before index

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.h

Issue 213773003: select.add() should support optgroup adding and before index (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLSelectElement.h

diff --git a/Source/core/html/HTMLSelectElement.h b/Source/core/html/HTMLSelectElement.h

index 8268cc15a8c3508e851f1278dbdbc0c98d14753c..e5dd1ed32aa204f6a3d5bb5801b15d86046d44db 100644

--- a/Source/core/html/HTMLSelectElement.h

+++ b/Source/core/html/HTMLSelectElement.h

@@ -63,6 +63,7 @@ public:

bool usesMenuList() const;

void add(HTMLElement*, HTMLElement* beforeElement, ExceptionState&);

+ void addBeforeOptionAtIndex(HTMLElement*, unsigned beforeIndex, ExceptionState&);

tkent 2014/03/27 06:13:35 Why the argument is unsigned though the argument i

keishi 2014/03/27 06:52:03 Done.

using Node::remove;

void remove(int index);