Source/core/html/HTMLOptionsCollection.cpp - Issue 213773003: select.add() should support optgroup adding and before index

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLOptionsCollection.cpp

Issue 213773003: select.add() should support optgroup adding and before index (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLOptionsCollection.cpp

diff --git a/Source/core/html/HTMLOptionsCollection.cpp b/Source/core/html/HTMLOptionsCollection.cpp

index d1abb1d3c23f1a98665710f3e1f94e168b1186e2..4a37c0ab0a6a4aedd5678cdf123ffbe247499d6a 100644

--- a/Source/core/html/HTMLOptionsCollection.cpp

+++ b/Source/core/html/HTMLOptionsCollection.cpp

@@ -93,7 +93,7 @@ void HTMLOptionsCollection::add(PassRefPtr<HTMLOptionElement> element, int index

if (index == -1 || unsigned(index) >= length())

select.add(newOption, 0, exceptionState);

else

- select.add(newOption, toHTMLOptionElement(item(index)), exceptionState);

+ select.addBeforeOptionAtIndex(newOption, unsigned(index), exceptionState);

ASSERT(!exceptionState.hadException());

}