Make compositing updates 30.7% faster for calculator

Source/core/rendering/RenderLayer.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 108 matching lines @@
     , m_hasVisibleContent(false)
     , m_visibleDescendantStatusDirty(false)
     , m_hasVisibleDescendant(false)
     , m_hasVisibleNonLayerContent(false)
     , m_isPaginated(false)
     , m_3DTransformedDescendantStatusDirty(true)
     , m_has3DTransformedDescendant(false)
     , m_containsDirtyOverlayScrollbars(false)
     , m_canSkipRepaintRectsUpdateOnScroll(renderer->isTableCell())
     , m_hasFilterInfo(false)
-    , m_needsToRecomputeBounds(true)
+    , m_needsToUpdateAncestorDependentProperties(true)
+    , m_childNeedsToUpdateAncestorDependantProperties(true)
     , m_renderer(renderer)
     , m_parent(0)
     , m_previous(0)
     , m_next(0)
     , m_first(0)
     , m_last(0)
     , m_staticInlinePosition(0)
     , m_staticBlockPosition(0)
     , m_enclosingPaginationLayer(0)
     , m_groupedMapping(0)
@@ skipping 1066 matching lines @@
 {
     const RenderLayer* curr = (includeSelf == IncludeSelf) ? this : parent();
     for (; curr; curr = curr->parent()) {
         if (curr->requiresFullLayerImageForFilters())
             return const_cast<RenderLayer*>(curr);
     }
 
     return 0;
 }
 
-void RenderLayer::clearNeedsToRecomputeBounds()
+void RenderLayer::setNeedsToUpdateAncestorDependentProperties()
 {
-    m_needsToRecomputeBounds = false;
+    m_needsToUpdateAncestorDependentProperties = true;
+
+    for (RenderLayer* current = this; current && !current->m_childNeedsToUpdateAncestorDependantProperties; current = current->parent())
+        current->m_childNeedsToUpdateAncestorDependantProperties = true;
 }
 
-void RenderLayer::setAbsoluteBoundingBox(const IntRect& rect)
+void RenderLayer::updateAncestorDependentProperties(const AncestorDependentProperties& ancestorDependentProperties)
 {
-    m_absoluteBoundingBox = rect;
-    clearNeedsToRecomputeBounds();
+    m_ancestorDependentProperties = ancestorDependentProperties;
+    m_needsToUpdateAncestorDependentProperties = false;
+}
+
+void RenderLayer::clearChildNeedsToUpdateAncestorDependantProperties()
+{
+    ASSERT(!m_needsToUpdateAncestorDependentProperties);
+    m_childNeedsToUpdateAncestorDependantProperties = false;
 }
 
 void RenderLayer::setCompositingReasons(CompositingReasons reasons, CompositingReasons mask)
 {
     ASSERT(reasons == (reasons & mask));
     if ((m_compositingProperties.compositingReasons & mask) == (reasons & mask))
         return;
     m_compositingProperties.compositingReasons = (reasons & mask) | (m_compositingProperties.compositingReasons & ~mask);
     m_clipper.setCompositingClipRectsDirty();
 }
@@ skipping 185 matching lines @@
 
     if (beforeChild) {
         beforeChild->setPreviousSibling(child);
         child->setNextSibling(beforeChild);
         ASSERT(beforeChild != child);
     } else
         setLastChild(child);
 
     child->setParent(this);
 
+    setNeedsToUpdateAncestorDependentProperties();
+
     if (child->stackingNode()->isNormalFlowOnly())
         m_stackingNode->dirtyNormalFlowList();
 
     if (!child->stackingNode()->isNormalFlowOnly() || child->firstChild()) {
         // Dirty the z-order list in which we are contained. The ancestorStackingContainerNode() can be null in the
         // case where we're building up generated content layers. This is ok, since the lists will start
         // off dirty in that case anyway.
         child->stackingNode()->dirtyStackingContainerZOrderLists();
     }
 
@@ skipping 2523 matching lines @@
     {
         // https://code.google.com/p/chromium/issues/detail?id=343759
         DisableCompositingQueryAsserts disabler;
         if (paintsWithFilters())
             didPaintWithFilters = true;
         updateFilters(oldStyle, renderer()->style());
     }
 
     compositor()->updateStyleDeterminedCompositingReasons(this);
 
+    setNeedsToUpdateAncestorDependentProperties();
+
     // FIXME: Remove incremental compositing updates after fixing the chicken/egg issues
     // https://code.google.com/p/chromium/issues/detail?id=343756
     DisableCompositingQueryAsserts disabler;
 
-    // FIXME: We could avoid doing this ancestor walk by keeping a childNeedsToRecomputeBounds bit
-    // and using that along with needsToRecomputeBounds to set this bit in a later layer tree walk
-    // e.g. during assignLayersToBackings or computeCompositingRequirements.
+    // FIXME: Move this work to CompositingPropertyUpdater::updateAncestorDependentProperties.
     if (RenderLayer* compositingLayer = enclosingCompositingLayer())
         compositingLayer->compositedLayerMapping()->setNeedsGeometryUpdate();
-    // FIXME: We only need to set this if something changed that can change our absolute bounding rect.
-    m_needsToRecomputeBounds = true;
 
     const RenderStyle* newStyle = renderer()->style();
 
     compositor()->updateLayerCompositingState(this, RenderLayerCompositor::UseChickenEggHacks);
     // FIXME: this compositing logic should be pushed into the compositing code, not here.
     if (needsCompositingLayersRebuiltForClip(oldStyle, newStyle)
         || needsCompositingLayersRebuiltForOverflow(oldStyle, newStyle)
         || needsCompositingLayersRebuiltForFilters(oldStyle, newStyle, didPaintWithFilters)
         || needsCompositingLayersRebuiltForBlending(oldStyle, newStyle)) {
         compositor()->setCompositingLayersNeedRebuild();
@@ skipping 182 matching lines @@
     }
 }
 
 void showLayerTree(const WebCore::RenderObject* renderer)
 {
     if (!renderer)
         return;
     showLayerTree(renderer->enclosingLayer());
 }
 #endif