runtime/lib/bool_patch.dart - Issue 2137673002: Sped up hashCode by removing megamorphic call to _identityHashCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/bool_patch.dart

Issue 2137673002: Sped up hashCode by removing megamorphic call to _identityHashCode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/bool_patch.dart

diff --git a/runtime/lib/bool_patch.dart b/runtime/lib/bool_patch.dart

index 274b1539757a09ffc899f3af755b8750c27f20d3..bbcbdb40264636641272b9d4c42ecf0c61cfd6f3 100644

--- a/runtime/lib/bool_patch.dart

+++ b/runtime/lib/bool_patch.dart

@@ -10,8 +10,6 @@ patch class bool {

{bool defaultValue: false})

native "Bool_fromEnvironment";

- int get _identityHashCode {

- return this ? 1231 : 1237;

- }

- int get hashCode => _identityHashCode;

+ int get hashCode => this ? 1231 : 1237;

+ int get _identityHashCode => this ? 1231 : 1237;

}