Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: runtime/lib/object_patch.dart

Issue 2137673002: Sped up hashCode by removing megamorphic call to _identityHashCode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Improved the speed of instance-of for unoptimized code. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 patch class Object { 5 patch class Object {
6 6
7 // The VM has its own implementation of equals. 7 // The VM has its own implementation of equals.
8 bool operator ==(other) native "Object_equals"; 8 bool operator ==(other) native "Object_equals";
9 9
10 // Helpers used to implement hashCode. If a hashCode is used, we remember it 10 // Helpers used to implement hashCode. If a hashCode is used, we remember it
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 _symbolMapToStringMap(invocation.namedArguments)); 51 _symbolMapToStringMap(invocation.namedArguments));
52 } 52 }
53 53
54 /* patch */ Type get runtimeType native "Object_runtimeType"; 54 /* patch */ Type get runtimeType native "Object_runtimeType";
55 55
56 // Call this function instead of inlining instanceof, thus collecting 56 // Call this function instead of inlining instanceof, thus collecting
57 // type feedback and reducing code size of unoptimized code. 57 // type feedback and reducing code size of unoptimized code.
58 bool _instanceOf(instantiator_type_arguments, type, bool negate) 58 bool _instanceOf(instantiator_type_arguments, type, bool negate)
59 native "Object_instanceOf"; 59 native "Object_instanceOf";
60 60
61 // Group of functions for implementing fast simple instance of.
62 bool _simpleInstanceOf(type) native "Object_simpleInstanceOf";
63 bool _simpleInstanceOfTrue(type) => true;
64 bool _simpleInstanceOfFalse(type) => false;
65
61 bool _instanceOfDouble(bool negate) native "Object_instanceOfDouble"; 66 bool _instanceOfDouble(bool negate) native "Object_instanceOfDouble";
62 bool _instanceOfNum(bool negate) native "Object_instanceOfNum"; 67 bool _instanceOfNum(bool negate) native "Object_instanceOfNum";
63 bool _instanceOfInt(bool negate) native "Object_instanceOfInt"; 68 bool _instanceOfInt(bool negate) native "Object_instanceOfInt";
64 bool _instanceOfSmi(bool negate) native "Object_instanceOfSmi"; 69 bool _instanceOfSmi(bool negate) native "Object_instanceOfSmi";
65 bool _instanceOfString(bool negate) native "Object_instanceOfString"; 70 bool _instanceOfString(bool negate) native "Object_instanceOfString";
66 71
67 // Call this function instead of inlining 'as', thus collecting type 72 // Call this function instead of inlining 'as', thus collecting type
68 // feedback. Returns receiver. 73 // feedback. Returns receiver.
69 _as(instantiator_type_arguments, type) native "Object_as"; 74 _as(instantiator_type_arguments, type) native "Object_as";
70 75
71 static _symbolMapToStringMap(Map<Symbol, dynamic> map) { 76 static _symbolMapToStringMap(Map<Symbol, dynamic> map) {
72 var result = new Map<String, dynamic>(); 77 var result = new Map<String, dynamic>();
73 map.forEach((Symbol key, value) { 78 map.forEach((Symbol key, value) {
74 result[internal.Symbol.getName(key)] = value; 79 result[internal.Symbol.getName(key)] = value;
75 }); 80 });
76 return result; 81 return result;
77 } 82 }
78 } 83 }
OLDNEW
« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698