Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2137623002: Fixes in CrNet and Cronet frameworks (Closed)

Created:
4 years, 5 months ago by kapishnikov
Modified:
4 years, 5 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes in CrNet and Cronet frameworks 1. Port https://codereview.chromium.org/2115653002/ to crnet_environment.mm 2. Port https://codereview.chromium.org/2110803002/ to crnet_environment.mm and cronet_environment.cc 3. Override CrNet FrameworkBundle, so that the icudtl.dat and IDS_ACCEPT_LANGUAGES can be read from the framework bundle itself. 4. Use base::mac::FrameworkBundle() instead of [NSBundle mainBundle]. Committed: https://crrev.com/f7b513096f4689b87b89d061530619eb57c1f5fa Cr-Commit-Position: refs/heads/master@{#404535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M components/cronet/ios/cronet_environment.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/crnet/crnet_environment.mm View 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kapishnikov
4 years, 5 months ago (2016-07-08 19:13:09 UTC) #2
mef
lgtm
4 years, 5 months ago (2016-07-08 22:10:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137623002/1
4 years, 5 months ago (2016-07-08 22:12:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 23:43:10 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 23:43:24 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 23:45:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7b513096f4689b87b89d061530619eb57c1f5fa
Cr-Commit-Position: refs/heads/master@{#404535}

Powered by Google App Engine
This is Rietveld 408576698