buildbucket: bypass Cloud Endpoints API server

buildbucket: bypass Cloud Endpoints API server

Cloud Endpoints API server causes occasional 404s and increases of latency.
We don't use the benefits that it provides, so bypass it.

This CL also vendors discovery doc from buildbucket, primarily because
apiclient API does not allow to manipulate API baseURL, but also it
simplfies code.

R=dnj@chromium.org
BUG=626650
Committed: https://chromium.googlesource.com/chromium/tools/build/+/01a9273aee506a2463a290c407eb4cd3599d53d3

[nodir, 2016-07-08 17:19:12]

PTAL

Tested locally

[nodir, 2016-07-08 17:22:25]

Description was changed from

==========
buildbucket: bypass Cloud Endpoints API server

Cloud Endpoints API server causes occasional 404s and increases of latency.
We don't use the benefits that it provides, so bypas it.

This CL also vendors discovery doc from buildbucket, primarily because
apiclient API does not allow to manipulate API baseURL, but also it
simplfies code.

R=dn@chromium.org
BUG=626650
==========

to

==========
buildbucket: bypass Cloud Endpoints API server

Cloud Endpoints API server causes occasional 404s and increases of latency.
We don't use the benefits that it provides, so bypas it.

This CL also vendors discovery doc from buildbucket, primarily because
apiclient API does not allow to manipulate API baseURL, but also it
simplfies code.

R=dnj@chromium.org
BUG=626650
==========

[nodir, 2016-07-08 17:22:26]

nodir@chromium.org changed reviewers:
+ dnj@chromium.org
- dn@chromium.org

[nodir, 2016-07-08 17:22:34]

-dn +dnj

[dnj (Google), 2016-07-08 17:37:29]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2016-07-08 17:37:29]

lgtm w/ nits

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
File scripts/master/buildbucket/client.py (right):

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
scripts/master/buildbucket/client.py:26: BYPASS_ENDPOINTS_WHITELIST = [
nit: might as well make this a set()

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
scripts/master/buildbucket/client.py:57: resource =
apiclient.discovery.Resource(
nit: Comment that this is copied from the source library.

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
File scripts/master/buildbucket/update_discovery_doc (right):

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
scripts/master/buildbucket/update_discovery_doc:2: curl
'https://cr-buildbucket.appspot.com/_ah/api/discovery/v1/apis/buildbucket/v1/rest'
> discovery_doc.json
nit: Either document that this needs to be run within the "buildbucket"
directory, or derive the directory name with:
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

[nodir, 2016-07-08 17:42:54]

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
File scripts/master/buildbucket/client.py (right):

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
scripts/master/buildbucket/client.py:26: BYPASS_ENDPOINTS_WHITELIST = [
On 2016/07/08 17:37:29, dnj (Google) wrote:
> nit: might as well make this a set()

Done.

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
scripts/master/buildbucket/client.py:57: resource =
apiclient.discovery.Resource(
On 2016/07/08 17:37:29, dnj (Google) wrote:
> nit: Comment that this is copied from the source library.

Done.

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
File scripts/master/buildbucket/update_discovery_doc (right):

https://codereview.chromium.org/2137583002/diff/20001/scripts/master/buildbuc...
scripts/master/buildbucket/update_discovery_doc:2: curl
'https://cr-buildbucket.appspot.com/_ah/api/discovery/v1/apis/buildbucket/v1/rest'
> discovery_doc.json
On 2016/07/08 17:37:29, dnj (Google) wrote:
> nit: Either document that this needs to be run within the "buildbucket"
> directory, or derive the directory name with:
> DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

Done.

[nodir, 2016-07-08 17:42:58]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-07-08 17:42:59]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@google.com
Link to the patchset: https://codereview.chromium.org/2137583002/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2016-07-08 17:43:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 17:51:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 17:51:12]

Try jobs failed on following builders:
  Build Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[nodir, 2016-07-08 17:52:36]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-07-08 17:52:36]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@google.com
Link to the patchset: https://codereview.chromium.org/2137583002/#ps60001
(title: "copyright in a tiny shell script")

[commit-bot: I haz the power, 2016-07-08 17:52:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-07-08 17:54:46]

Description was changed from

==========
buildbucket: bypass Cloud Endpoints API server

Cloud Endpoints API server causes occasional 404s and increases of latency.
We don't use the benefits that it provides, so bypas it.

This CL also vendors discovery doc from buildbucket, primarily because
apiclient API does not allow to manipulate API baseURL, but also it
simplfies code.

R=dnj@chromium.org
BUG=626650
==========

to

==========
buildbucket: bypass Cloud Endpoints API server

Cloud Endpoints API server causes occasional 404s and increases of latency.
We don't use the benefits that it provides, so bypass it.

This CL also vendors discovery doc from buildbucket, primarily because
apiclient API does not allow to manipulate API baseURL, but also it
simplfies code.

R=dnj@chromium.org
BUG=626650
==========

[tandrii(chromium), 2016-07-08 17:54:58]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-07-08 17:54:58]

LGTM, thanks!

[commit-bot: I haz the power, 2016-07-08 17:57:00]

Description was changed from

==========
buildbucket: bypass Cloud Endpoints API server

Cloud Endpoints API server causes occasional 404s and increases of latency.
We don't use the benefits that it provides, so bypass it.

This CL also vendors discovery doc from buildbucket, primarily because
apiclient API does not allow to manipulate API baseURL, but also it
simplfies code.

R=dnj@chromium.org
BUG=626650
==========

to

==========
buildbucket: bypass Cloud Endpoints API server

Cloud Endpoints API server causes occasional 404s and increases of latency.
We don't use the benefits that it provides, so bypass it.

This CL also vendors discovery doc from buildbucket, primarily because
apiclient API does not allow to manipulate API baseURL, but also it
simplfies code.

R=dnj@chromium.org
BUG=626650

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/01a9273aee506a2463a2...
==========

[commit-bot: I haz the power, 2016-07-08 17:57:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/01a9273aee506a2463a2...