Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2137573002: 🙈 Remove incorrect runtime_library dependency from webapk target (Closed)

Created:
4 years, 5 months ago by pkotwicz
Modified:
4 years, 5 months ago
Reviewers:
Xi Han
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

🙈 Remove incorrect runtime_library dependency from webapk target BUG=None Committed: https://crrev.com/fbd867e3f31e1537cc0e1f4962ed1118d3a8e5ce Cr-Commit-Position: refs/heads/master@{#404437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/android/webapk/shell_apk/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pkotwicz
Xi can you please take a look?
4 years, 5 months ago (2016-07-08 15:49:13 UTC) #2
Xi Han
lgtm
4 years, 5 months ago (2016-07-08 16:16:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2137573002/1
4 years, 5 months ago (2016-07-08 16:18:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 18:05:38 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 18:05:45 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 18:09:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbd867e3f31e1537cc0e1f4962ed1118d3a8e5ce
Cr-Commit-Position: refs/heads/master@{#404437}

Powered by Google App Engine
This is Rietveld 408576698