third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp - Issue 2137483004: Enable "system-ui" generic font family

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

Issue 2137483004: Enable "system-ui" generic font family (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: drott nit Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp b/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

index 16678e70b19b88a6feb4f67e57f32b195d9e5e93..f163cdd6ee0717fd5e44c064e0dd3b59d5bc9f57 100644

--- a/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

+++ b/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp

@@ -211,6 +211,7 @@ sk_sp<SkTypeface> FontCache::createTypeface(

#endif

AtomicString family = creationParams.family();

+ DCHECK_NE(family, FontFamilyNames::system_ui);

// If we're creating a fallback font (e.g. "-webkit-monospace"), convert the

// name into the fallback name (like "monospace") that fontconfig understands.

if (!family.length() || family.startsWith("-webkit-")) {