Enable "system-ui" generic font family

third_party/WebKit/Source/platform/fonts/mac/FontCacheMac.mm

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 43 matching lines @@
              inLanguage:(id)useNil;
 + (NSFont*)findFontLike:(NSFont*)font
            forCharacter:(UniChar)uc
              inLanguage:(id)useNil;
 @end
 
 namespace blink {
 
 const char* kColorEmojiFontMac = "Apple Color Emoji";
 
+// static
+const AtomicString& FontCache::legacySystemFontFamily() {
+  DEFINE_STATIC_LOCAL(AtomicString, legacySystemFontFamily,
+                      ("BlinkMacSystemFont"));
+  return legacySystemFontFamily;
+}
+
+// static
+const AtomicString& FontCache::systemFontFamily(float) {

[drott, 2016/10/12 11:01:59]

When will you need the parameter? If Mac instantiates with "systemFontForSize"
in FontFamilyMatcherMac, do we need this parameter here?

[kojii, 2016/10/12 11:14:52]

I'm thinking to replace "system-ui" with ".SF NS Text" or ".SF NS Display", then
with the list of cascading list. By replacing family name in this stage, we get
different FontData for each actual fonts.

This API surface supports only the first phase. I believe it's the significant
part of broken letter spacing, and would like to consider the design when I'm
more in sync with your plan to deprecate FontFallbackList and SimpleFontData.

I haven't really well tested replacing ".SF NS Text"/".SF NS Display" works well
yet, should have it soon. That said, this may need a revise, or two. I just
added size now because that gives me where FontCache can replace the family name
(i.e., only after it computed the size and know the locale.)

[drott, 2016/10/13 07:59:34]

So you're saying you would like to move the replacement/resolution of system-ui
from MatchNSFontFamily to here in order for use to get different
FontPlatformData objects?

[kojii, 2016/10/13 09:03:20]

Yes, that way we can keep one SkTypeface/SimpleFontData/hb to map to single
OpenType font. It's not working really well yet, I need more your help on this
(will send separate e-mail) but I hope the direction is right?

[drott, 2016/10/13 12:36:13]

Yes, sounds reasonable.

+  // TODO(kojii): Get the actual font name for the size.
+  return FontFamilyNames::system_ui;
+}
+
 static void invalidateFontCache() {
   if (!isMainThread()) {
     Platform::current()->mainThread()->getWebTaskRunner()->postTask(
         BLINK_FROM_HERE, WTF::bind(&invalidateFontCache));
     return;
   }
   FontCache::fontCache()->invalidate();
 }
 
 static void fontCacheRegisteredFontsChangedNotificationCallback(
@@ skipping 203 matching lines @@
   std::unique_ptr<FontPlatformData> platformData = wrapUnique(
       new FontPlatformData(platformFont, size, syntheticBold, syntheticItalic,
                            fontDescription.orientation()));
   if (!platformData->typeface()) {
     return nullptr;
   }
   return platformData;
 }
 
 }  // namespace blink