third_party/WebKit/Source/core/events/EventTarget.h - Issue 2137483003: Add UMA metrics for root scroller intervention to track forcing passive breakage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.h

Issue 2137483003: Add UMA metrics for root scroller intervention to track forcing passive breakage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comment to clarify implementation point Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/events/AddEventListenerOptionsResolved.h ('K') | « third_party/WebKit/Source/core/events/EventListenerMap.cpp ('k') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('j') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/EventTarget.h

diff --git a/third_party/WebKit/Source/core/events/EventTarget.h b/third_party/WebKit/Source/core/events/EventTarget.h

index 2b913871a7187c2dfdb3d21c4cc338670182a811..a4ea66f2908df63c533af40e1994191d00cac6fe 100644

--- a/third_party/WebKit/Source/core/events/EventTarget.h

+++ b/third_party/WebKit/Source/core/events/EventTarget.h

@@ -39,6 +39,7 @@

#include "core/EventNames.h"

#include "core/EventTargetNames.h"

#include "core/EventTypeNames.h"

+#include "core/events/AddEventListenerOptionsResolved.h"

#include "core/events/EventDispatchResult.h"

#include "core/events/EventListenerMap.h"

#include "platform/heap/Handle.h"

@@ -117,7 +118,7 @@ public:

bool addEventListener(const AtomicString& eventType, EventListener*, bool useCapture = false);

bool addEventListener(const AtomicString& eventType, EventListener*, const AddEventListenerOptionsOrBoolean&);

- bool addEventListener(const AtomicString& eventType, EventListener*, AddEventListenerOptions&);

+ bool addEventListener(const AtomicString& eventType, EventListener*, AddEventListenerOptionsResolved&);

bool removeEventListener(const AtomicString& eventType, const EventListener*, bool useCapture = false);

bool removeEventListener(const AtomicString& eventType, const EventListener*, const EventListenerOptionsOrBoolean&);

@@ -155,7 +156,7 @@ public:

protected:

EventTarget();

- virtual bool addEventListenerInternal(const AtomicString& eventType, EventListener*, const AddEventListenerOptions&);

+ virtual bool addEventListenerInternal(const AtomicString& eventType, EventListener*, const AddEventListenerOptionsResolved&);

virtual bool removeEventListenerInternal(const AtomicString& eventType, const EventListener*, const EventListenerOptions&);

// Called when an event listener has been successfully added.

@@ -173,7 +174,7 @@ protected:

private:

LocalDOMWindow* executingWindow();

- void setDefaultAddEventListenerOptions(const AtomicString& eventType, AddEventListenerOptions&);

+ void setDefaultAddEventListenerOptions(const AtomicString& eventType, AddEventListenerOptionsResolved&);

bool fireEventListeners(Event*, EventTargetData*, EventListenerVector&);

void countLegacyEvents(const AtomicString& legacyTypeName, EventListenerVector*, EventListenerVector*);